List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:December 16 2008 6:05pm
Subject:Re: bzr commit into mysql-6.0 branch (jperkin:2796) Bug#30708
View as plain text  
Hi Jonathan,


Jonathan Perkin wrote:
> #At file:///home/sketch/bzr/mysql-6.0-build-bug30708/ based on
> revid:build@stripped
> 
>  2796 Jonathan Perkin	2008-12-12
>       bug#30708: make relies GNU extensions.  Now that we no longer use
>       BitKeeper we can safely remove the SCCS handling with no loss of
>       functionality.
> modified:
>   BUILD/Makefile.am
>   [[...]]
>   libmysql/Makefile.am
>   libmysql/Makefile.shared
>   libmysql_r/Makefile.am
>   [[...]]
> 
> === modified file 'BUILD/Makefile.am'
> --- a/BUILD/Makefile.am	2008-05-13 13:58:07 +0000
> +++ b/BUILD/Makefile.am	2008-12-12 13:06:30 +0000
> @@ -84,6 +84,3 @@
>  			compile-sparc \
>  			compile-sparc-debug \
>  			compile-sparc-debug-max-no-ndb
> -
> -# Don't update the files from bitkeeper
> -%::SCCS/s.%
> 
> [[...]]

Approved.

In a local test, I still got some warnings about using GNU-specific
features in our Makefiles, but we should leave them to a second round.


Jörg

-- 
Joerg Bruehe,  MySQL Build Team,
               Joerg.Bruehe@stripped   (+49 30) 417 01 487
Sun Microsystems GmbH,   Sonnenallee 1,   D-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering     Muenchen: HRB161028

Thread
bzr commit into mysql-6.0 branch (jperkin:2796) Bug#30708Jonathan Perkin12 Dec
  • Re: bzr commit into mysql-6.0 branch (jperkin:2796) Bug#30708Joerg Bruehe16 Dec