List:Commits« Previous MessageNext Message »
From:knielsen Date:January 4 2006 3:02pm
Subject:bk commit into 5.0 tree (knielsen:1.2010)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of knielsen. When knielsen does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2010 06/01/04 16:02:41 knielsen@stripped +1 -0
  Fix QNX test abort in release builds and pushbuild, avoid killing our
  parent when we are not the process group leader.

  mysql-test/lib/mtr_process.pl
    1.25 06/01/04 16:02:02 knielsen@stripped +8 -1
    Fix QNX test abort in release builds and pushbuild, avoid killing our
    parent when we are not the process group leader.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	knielsen
# Host:	rt.int.sifira.dk
# Root:	/usr/local/mysql/mysql-5.0-qnxfix

--- 1.24/mysql-test/lib/mtr_process.pl	2005-10-16 20:30:22 +02:00
+++ 1.25/mysql-test/lib/mtr_process.pl	2006-01-04 16:02:02 +01:00
@@ -890,7 +890,14 @@
 #  cluck("Called mtr_exit()");
   mtr_timer_stop_all($::glob_timers);
   local $SIG{HUP} = 'IGNORE';
-  kill('HUP', -$$);
+  # ToDo: Signalling -$$ will only work if we are the process group
+  # leader (in fact on QNX it will signal our session group leader,
+  # which might be Do-compile or Pushbuild, causing tests to be
+  # aborted). So we only do it if we are the group leader. We might
+  # set ourselves as the group leader at startup (with
+  # POSIX::setpgrp(0,0)), but then care must be needed to always do
+  # proper child process cleanup.
+  kill('HUP', -$$) if $$ == getpgrp();
   sleep 2;
   exit($code);
 }
Thread
bk commit into 5.0 tree (knielsen:1.2010)knielsen4 Jan