bzr push into mysql-5.1-bugteam branch (kgeorge:2727 to 2728) Bug#41255

[Georgi Kodinov]

 2728 Georgi Kodinov	2008-12-05
      Disable wait_timeout_func and report bug #41255.
modified:
  mysql-test/t/disabled.def

 2727 Vladislav Vaintroub	2008-12-04
      Bug#38522: 5 seconds delay when closing application using embedded server
      
                        
      The problem here is that embedded server starts handle_thread manager 
      thread  on mysql_library_init() does not stop it on mysql_library_end().
      At shutdown, my_thread_global_end() waits for thread count to become 0,
      but since we did not stop the thread it will give up after 5 seconds.
                   
      Solution is to move shutdown for handle_manager thread from kill_server()
      (mysqld specific) to clean_up() that is used by both embedded and mysqld.
                  
      This patch also contains some refactorings - to avoid duplicate code,
      start_handle_manager() and stop_handle_manager() functions are introduced.
      Unused variables are eliminated. handle_manager does not rely on global
      variable abort_loop anymore to stop (abort_loop is not set for embedded).
                  
      Note: Specifically on Windows and when using DBUG version of libmysqld, 
      the complete solution requires removing obsolete code my_thread_init() 
      from my_thread_var(). This has a side effect that a DBUG statement 
      after my_thread_end() can cause thread counter to be incremented, and 
      embedded will hang for some seconds. Or worse, my_thread_init() will 
      crash if critical sections have been deleted by the global cleanup 
      routine that runs in a different thread. 
      
      This patch also fixes and revert prior changes for Bug#38293 
      "Libmysqld crash in mysql_library_init if language file missing".
      
      Root cause of the crash observed in Bug#38293  was bug in my_thread_init() 
      described above
modified:
  client/mysql.cc
  dbug/dbug.c
  include/my_dbug.h
  libmysql/libmysql.c
  libmysqld/examples/CMakeLists.txt
  libmysqld/lib_sql.cc
  libmysqld/libmysqld.def
  mysys/my_thr_init.c
  sql/mysql_priv.h
  sql/mysqld.cc
  sql/sql_manager.cc

=== modified file 'mysql-test/t/disabled.def'
--- a/mysql-test/t/disabled.def	2008-11-17 20:25:27 +0000
+++ b/mysql-test/t/disabled.def	2008-12-05 11:24:19 +0000
@@ -12,3 +12,4 @@
 federated_transactions   : Bug#29523 Transactions do not work
 log_tables.test                       : Bug #37798: main.log_tables fails randomly on powermacg5 and windows
 slow_query_log_func.test              : Bug #37962: *_func tests containing sleeps/race conditions
+wait_timeout_func    : Bug #41225 joro wait_timeout_func fails