bzr commit into mysql-5.1 branch (aelkin:2703) Bug#41173

[Andrei Elkin]

#At file:///home/andrei/MySQL/BZR/FIXES/5.1-rpl-bug41173-rpl_packet-slave_star_not_synched/

 2703 Andrei Elkin	2008-12-02
      bug#41173 rpl_packet fails sporadically on pushbuild: query 'DROP TABLE t1' failed 
      
      The problem is most probably is missing synchronization in mtr with the slave io thread state.
      The io thread is not guaranteed to be connected by the end of `start slave'.
      
      Fixed with deploying wait_for_slave_to_start.inc macro invocation.
modified:
  mysql-test/include/wait_for_slave_to_start.inc
  mysql-test/suite/rpl/t/rpl_packet.test

per-file messages:
  mysql-test/include/wait_for_slave_to_start.inc
    Added an important piece to the specification.
  mysql-test/suite/rpl/t/rpl_packet.test
    Invoked a necessary synchronization macro.
    The slave IO is not guaranteed to be connected by the end of `start slave' but the macro does.
=== modified file 'mysql-test/include/wait_for_slave_to_start.inc'
--- a/mysql-test/include/wait_for_slave_to_start.inc	2008-07-10 16:09:39 +0000
+++ b/mysql-test/include/wait_for_slave_to_start.inc	2008-12-02 14:59:44 +0000
@@ -1,7 +1,8 @@
 # ==== Purpose ====
 #
 # Waits until both the IO and SQL threads of the current connection
-# have started, or until a timeout is reached.
+# have started, the IO thread has connected to the master 
+# or until a timeout is reached.
 #
 # ==== Usage ====
 #
@@ -13,6 +14,10 @@
 
 let $slave_error_message= Failed while waiting for slave to start;
 
+#
+# The running status YES designates the slave IO thread has connected
+# to the master
+#
 let $slave_param= Slave_IO_Running;
 let $slave_param_value= Yes;
 source include/wait_for_slave_param.inc;

=== modified file 'mysql-test/suite/rpl/t/rpl_packet.test'
--- a/mysql-test/suite/rpl/t/rpl_packet.test	2008-11-13 19:19:00 +0000
+++ b/mysql-test/suite/rpl/t/rpl_packet.test	2008-12-02 14:59:44 +0000
@@ -22,6 +22,7 @@ SET @@global.net_buffer_length=1024;
 connection slave;
 source include/stop_slave.inc;
 source include/start_slave.inc;
+source include/wait_for_slave_to_start.inc; 
 
 # Reconnect to master for new setting to take effect
 disconnect master;