List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:December 2 2008 11:15am
Subject:bzr commit into mysql-5.1-bugteam branch (kgeorge:2725) Bug#39178
View as plain text  
#At file:///home/kgeorge/mysql/work/fix-5.1-bugteam/ based on revid:kgeorge@stripped

 2725 Georgi Kodinov	2008-12-02
      Addendum to the fix for bug #39178: Server crash in YaSSL 
      with non-RSA-requesting client if server uses RSA key
      
      matchSuite() may not find a match. 
      It will return error in this case.
      Added a error checking code that will prevent using uninitialized 
      memory in the code based on the assumption 
      that matchSuite() has found a match.
modified:
  extra/yassl/src/yassl_imp.cpp

per-file messages:
  extra/yassl/src/yassl_imp.cpp
    Bug #39178: Correct error checking added
=== modified file 'extra/yassl/src/yassl_imp.cpp'
--- a/extra/yassl/src/yassl_imp.cpp	2008-11-18 16:45:44 +0000
+++ b/extra/yassl/src/yassl_imp.cpp	2008-12-02 11:15:28 +0000
@@ -1560,6 +1560,7 @@ void ClientHello::Process(input_buffer&,
         return;
     }
     ssl.matchSuite(cipher_suites_, suite_len_);
+    if (ssl.GetError()) return;
     ssl.set_pending(ssl.getSecurity().get_parms().suite_[1]);
 
     if (compression_methods_ == zlib)

Thread
bzr commit into mysql-5.1-bugteam branch (kgeorge:2725) Bug#39178Georgi Kodinov2 Dec