Re: bzr commit into mysql-6.0-falcon-team branch (cpowers:2922) Bug#40994

[Hakan Kuecuekyilmaz]

Chris,

one detail, see inline.

On Mo, 2008-12-01 at 16:18 -0600, Christopher Powers wrote:
> #At file:///home/cpowers/work/dev/dev-13/mysql/
> 
>  2922 Christopher Powers	2008-12-01
>       Bug#40994, "Regression: can't create unique index on NOT NULL columns if engine
> is falcon"
>       
>       The MySQL server interprets unique indexes on NOT NULL columns as a primary
> key.
>       Falcon online add/drop index does not yet support primary keys.
> added:
>   mysql-test/suite/falcon/r/falcon_bug_40994.result
>   mysql-test/suite/falcon/t/falcon_bug_40994.test
> modified:
>   storage/falcon/ha_falcon.cpp
> 
> per-file messages:
>   mysql-test/suite/falcon/r/falcon_bug_40994.result
>     Result file for Bug#40994 testcase
>   mysql-test/suite/falcon/t/falcon_bug_40994.test
>     New testcase, Bug#40994
>   storage/falcon/ha_falcon.cpp
>     If new index is a primary key, create the index offline.
> === added file 'mysql-test/suite/falcon/r/falcon_bug_40994.result'
> --- a/mysql-test/suite/falcon/r/falcon_bug_40994.result	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/suite/falcon/r/falcon_bug_40994.result	2008-12-01 22:18:34 +0000
> @@ -0,0 +1,19 @@
> +*** Bug #40994 ***
> +SET @@storage_engine = 'Falcon';
> +DROP TABLE IF EXISTS t1;
> +CREATE TABLE t1 (a int(11) NOT NULL ) ENGINE=Falcon DEFAULT CHARSET=latin1;

Please use
   CREATE TABLE t1 (a int(11) NOT NULL );

because you are setting the default storage engine in the line above
already:
   SET @@storage_engine = 'Falcon';

Best,

Hakan

-- 
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160
98953296
Sun Microsystems GmbH     Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer:  Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering   HRB MUC 161028     49.011, 8.376