bzr commit into mysql-5.1 branch (ingo.struewing:2713) Bug#28234

[Ingo Struewing]

#At file:///home2/mydev/bzrroot/mysql-5.1-bug28234-1/

 2713 Ingo Struewing	2008-11-27
      Bug#28234 - global/session scope - documentation vs implementation
      
      Post-pushbuild fix.
      
      - Windows does not have 'socket' system variable.
      - Compiler warning in sql/slave.cc
modified:
  mysql-test/r/variables.result
  mysql-test/t/variables.test
  sql/slave.cc

per-file messages:
  mysql-test/r/variables.result
    Bug#28234 - global/session scope - documentation vs implementation
    Updated test result.
  mysql-test/t/variables.test
    Bug#28234 - global/session scope - documentation vs implementation
    Removed test for 'socket' variable. Windows doesn't have it.
  sql/slave.cc
    Bug#28234 - global/session scope - documentation vs implementation
    Changed type of constant to avoid a compiler warning.
=== modified file 'mysql-test/r/variables.result'
--- a/mysql-test/r/variables.result	2008-11-21 23:22:21 +0000
+++ b/mysql-test/r/variables.result	2008-11-27 10:50:28 +0000
@@ -1325,19 +1325,6 @@ ERROR HY000: Variable 'skip_show_databas
 SET @@global.skip_show_database= true;
 ERROR HY000: Variable 'skip_show_database' is a read only variable
 #
-SHOW VARIABLES like 'socket';
-Variable_name	Value
-socket	#
-SELECT @@session.socket;
-ERROR HY000: Variable 'socket' is a GLOBAL variable
-SELECT @@global.socket;
-@@global.socket
-#
-SET @@session.socket= 'x';
-ERROR HY000: Variable 'socket' is a read only variable
-SET @@global.socket= 'x';
-ERROR HY000: Variable 'socket' is a read only variable
-#
 SHOW VARIABLES like 'thread_stack';
 Variable_name	Value
 thread_stack	#

=== modified file 'mysql-test/t/variables.test'
--- a/mysql-test/t/variables.test	2008-11-21 23:22:21 +0000
+++ b/mysql-test/t/variables.test	2008-11-27 10:50:28 +0000
@@ -1067,18 +1067,6 @@ SET @@global.skip_show_database= true;
 #
 --echo #
 --replace_column 2 #
-SHOW VARIABLES like 'socket';
---error ER_INCORRECT_GLOBAL_LOCAL_VAR
-SELECT @@session.socket;
---replace_column 1 #
-SELECT @@global.socket;
---error ER_INCORRECT_GLOBAL_LOCAL_VAR
-SET @@session.socket= 'x';
---error ER_INCORRECT_GLOBAL_LOCAL_VAR
-SET @@global.socket= 'x';
-#
---echo #
---replace_column 2 #
 SHOW VARIABLES like 'thread_stack';
 --error ER_INCORRECT_GLOBAL_LOCAL_VAR
 SELECT @@session.thread_stack;

=== modified file 'sql/slave.cc'
--- a/sql/slave.cc	2008-11-21 23:22:21 +0000
+++ b/sql/slave.cc	2008-11-27 10:50:28 +0000
@@ -288,7 +288,7 @@ static void print_slave_skip_errors(void
     10 characters must be sufficient for a number plus {',' | '...'}
     plus a NUL terminator. That is a max 6 digit number.
   */
-  const int MIN_ROOM= 10;
+  const size_t MIN_ROOM= 10;
   DBUG_ENTER("print_slave_skip_errors");
   DBUG_ASSERT(sizeof(slave_skip_error_names) > MIN_ROOM);
   DBUG_ASSERT(MAX_SLAVE_ERROR <= 999999); // 6 digits