Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747) Bug#40307

[Rafal Somla]

Thanks for the review.

Jørgen Løland wrote:
> Rafal,
> 
> Patch looks good, although a recent push to the backup branch made the 
> patch-command fail. You'll probably have to re-commit.
> 

Of course.

> Status:
> -------
> Patch approved
> 
> Comment:
> --------
> Very clear comment on the string length! (But is "<...>" called "elipsis"?)
> 

No, actually it is called "ellipsis": <http://en.wikipedia.org/wiki/Ellipsis>. 
I'll fix the typo before pushing.

> Rafal Somla wrote:
>> #At file:///ext/mysql/bzr/backup/bug40307/
>>
>>  2747 Rafal Somla    2008-11-25
>>       BUG#40307 - Backup: The list of databases processed by 
>> BACKUP/RESTORE not                   logged.
>>             After this patch, the trace from BACKUP/RESTOE commands 
>> left in server's error       log (master.err) will look as follows:
>>              [Note] Backup: Starting backup process
>>        [Note] Backup: Backing up NN database(s) <list of databases>
>>        [Note] Backup: Backup completed
>>              [Note] Restore: Starting restore process
>>        [Note] Restore: Restoring NN database(s) <list of databases>
>>        [Note] Restore: Restore completed
>>             This way DBA can find out which databases are affected by 
>> the operation.
>>             Database list is reported in Logger::report_stats_pre() 
>> which is called after       initializing backup/restore catalogue and 
>> before performing backup of table       data.
> 
>