List:Commits« Previous MessageNext Message »
From:Jørgen Løland Date:November 26 2008 11:44am
Subject:Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747)
Bug#40307
View as plain text  
Rafal,

Patch looks good, although a recent push to the backup branch made the 
patch-command fail. You'll probably have to re-commit.

Status:
-------
Patch approved

Comment:
--------
Very clear comment on the string length! (But is "<...>" called "elipsis"?)

Rafal Somla wrote:
> #At file:///ext/mysql/bzr/backup/bug40307/
> 
>  2747 Rafal Somla	2008-11-25
>       BUG#40307 - Backup: The list of databases processed by BACKUP/RESTORE not 
>                   logged.
>       
>       After this patch, the trace from BACKUP/RESTOE commands left in server's error
> 
>       log (master.err) will look as follows:
>       
>        [Note] Backup: Starting backup process
>        [Note] Backup: Backing up NN database(s) <list of databases>
>        [Note] Backup: Backup completed
>       
>        [Note] Restore: Starting restore process
>        [Note] Restore: Restoring NN database(s) <list of databases>
>        [Note] Restore: Restore completed
>       
>       This way DBA can find out which databases are affected by the operation.
>       
>       Database list is reported in Logger::report_stats_pre() which is called after 
>       initializing backup/restore catalogue and before performing backup of table 
>       data.


-- 
Jørgen Løland
Thread
bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747) Bug#40307Rafal Somla25 Nov
  • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747)Bug#40307Jørgen Løland26 Nov
    • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747)Bug#40307Rafal Somla26 Nov
  • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2747)Bug#40307Øystein Grøvlen26 Nov