Rafal Somla wrote:
> Hi Oystein,
>
> Øystein Grøvlen wrote:
>> Rafal,
>>
>> Code changes looks good to me, but when doing some manual testing, I
>> noticed the following output when backing up 76 databases:
>>
>> Backup: Backing up database(s)
>>
> `test`,`test1`,`test10`,`test11`,`test12`,`test13`,`test14`,`test15`,`test16`,`test17`,`test18`,`test19`,`test2`,`test20`,`test21`,`test22`,`test23`,`test24`,`test25`,`test26`,`test27`,`test28`,`test29`,`test3`,`test30`,`test31`,`test32`,`test33`,`test
>
>>
>>
>> The list is chopped off at about 250 characters.
>>
>
> This is "by design", but perhaps a better design can be implemented.
> I'll try something like this:
>
> Backup: Backing up 76 database(s) `test`,`test1`,<other but not all
> databases>,...
>
> (note elipsis at the end).
I agree - the list of db's should be chopped. Apart from that the code
looks good. Will perform a new review once a new patch is ready.
--
Jørgen Løland
