Re: bzr commit into mysql-6.0-falcon-team branch (olav:2916) Bug#39419

[Olav Sandstaa]

Hi Vlad,

Thanks for reviewing the patch. I will update the preprocessor constant 
before I push the patch.

Olav

Vladislav Vaintroub wrote:
> Hi Olav,
>
>
>   
>> -----Original Message-----
>> From: Olav Sandstaa [mailto:olav@stripped]
>> Sent: Sunday, November 23, 2008 11:03 PM
>> To: commits@stripped
>> Subject: bzr commit into mysql-6.0-falcon-team branch (olav:2916)
>> Bug#39419
>> +#if (defined(__GNUC__) && !defined(__EXCEPTIONS)) || (defined
>> (_MSVC_VER) && !defined (_CPPUNWIND))
>> +#error Falcon needs to be compiled with support for C++ exceptions.
>> Please check your compiler settings.
>> +#endif
>> +
>>     
>
> The preprocessor constant is for Microsoft compiler is _MSC_VER , not
> _MSVC_VER (guess back in the 80th  it was just  Microsoft C compiler,
> without Visual :)
> Looks good otherwise.
>
>
>