List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:November 25 2008 8:24am
Subject:Re: bzr commit into mysql-5.1 branch (skozlov:2704) Bug#40708
View as plain text  
Serge, salut!

The patch is okay.
Still, could you please structure the top level comments to describe
the problem and the solution.

Thanks!

Andrei


> #At file:///home/ksm/sun/repo/bug40708/mysql-5.1-rpl/ based on
> revid:aelkin@stripped
>
>  2704 Serge Kozlov	2008-11-25
>       Bug#40708: Added DROP DATABASE as cleanup operation.
> modified:
>   mysql-test/suite/rpl/r/rpl_row_create_table.result
>   mysql-test/suite/rpl/t/rpl_row_create_table.test
>
> === modified file 'mysql-test/suite/rpl/r/rpl_row_create_table.result'
> --- a/mysql-test/suite/rpl/r/rpl_row_create_table.result	2008-10-23 19:27:09 +0000
> +++ b/mysql-test/suite/rpl/r/rpl_row_create_table.result	2008-11-24 21:03:27 +0000
> @@ -436,11 +436,13 @@ reset master;
>  reset slave;
>  drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
>  start slave;
> +DROP DATABASE IF EXISTS mysqltest1;
>  CREATE DATABASE mysqltest1;
>  CREATE TABLE mysqltest1.without_select (f1 BIGINT);
>  CREATE TABLE mysqltest1.with_select AS SELECT 1 AS f1;
>  show binlog events from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
> +master-bin.000001	#	Query	#	#	DROP DATABASE IF EXISTS mysqltest1
>  master-bin.000001	#	Query	#	#	CREATE DATABASE mysqltest1
>  master-bin.000001	#	Query	#	#	use `test`; CREATE TABLE mysqltest1.without_select (f1
> BIGINT)
>  master-bin.000001	#	Query	#	#	use `test`; BEGIN
>
> === modified file 'mysql-test/suite/rpl/t/rpl_row_create_table.test'
> --- a/mysql-test/suite/rpl/t/rpl_row_create_table.test	2008-10-23 19:27:09 +0000
> +++ b/mysql-test/suite/rpl/t/rpl_row_create_table.test	2008-11-24 21:03:27 +0000
> @@ -266,6 +266,9 @@ sync_slave_with_master;
>  source include/master-slave-reset.inc;
>  
>  connection master;
> +--disable_warnings
> +DROP DATABASE IF EXISTS mysqltest1;
> +--enable_warnings
>  CREATE DATABASE mysqltest1;
>  
>  CREATE TABLE mysqltest1.without_select (f1 BIGINT);
>
>
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1
Thread
bzr commit into mysql-5.1 branch (skozlov:2704) Bug#40708Serge Kozlov24 Nov
  • Re: bzr commit into mysql-5.1 branch (skozlov:2704) Bug#40708Andrei Elkin25 Nov
    • Re: bzr commit into mysql-5.1 branch (skozlov:2704) Bug#40708Serge Kozlov25 Nov