Hi Chuck,
Thank you for the review.
Chuck Bell wrote:
> STATUS
> ------
> Changes requested.
>
> REQUESTS
> --------
> 1. Spelling error in patch comments.
Fixed.
> 2. The new error ER_BACKUP_VP_FAILED is not tested. Please add a test
> case for this condition (appears in two locations in the code).
Reporting error from commit blocker is not rally in the scope of this patch.
Hence I removed this code from the patch and reported new Bug #40970 (Errors
from commit blocker are not logged).
>
> COMMENTARY
> ----------
> 3. Patch does not apply correctly to current tree. Got this rejection:
>
I updated the patch for the recent backup tree.
The new patch is this: http://lists.mysql.com/commits/59661. See if you can
accept it.
Rafal
