Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2734) Bug#40262

[Øystein Grøvlen]

Rafal Somla wrote:
 > Hi,
 >
 > Thanks for the review. I'll apply the requested/suggested changes before
 > pushing.
 >
 > Øystein Grøvlen wrote:
...

 >>> +
 >>> +# wait few seconds so that restore time != backup time
 >>> +--sleep 2
 >>
 >> [1]  I do not understand the purpose of sleep here.  Why does restore
 >> time have to be different from backup time.
 >
 > If restore time is identical to backup time, then it could happen
 > (theoretically) that even with incorrect code the validity_point_time =
 > @vp_time test below passes. For example if
 > backup_history.validity_point_time is not set to the value read from
 > backup image but to the time when RESTORE was executed.

I see your point, and I accept that this make sense since your
scenario is more likely than that incorrect code could cause
validity_point_time to always be current time minus a constant.

--
Øystein