Hi Hakan,
For all disabled tests, please add comments to all relevant bug reports
(in this case bugs 40807, 40808, 37281) where you state clearly that the
tests have been disabled due to those bugs, and that they should be
re-enabled once the bug is fixed. Otherwise it could be easily forgotten
and we end up with out-of-sync disabled.def files.
Regarding tests backup_ptr_row and backup_ptr_mixed:
I just wanted to mention one alternative solution in case Bug#37281
(Falcon big-endian date/time bug) is not fixed soon enough, and we start
worrying about missing test coverage for other engines than Falcon...
I think if you add
--source suite/backup_engines/include/not_have_falcon.inc
to the tests, they will be skipped when the Falcon engine is used (i.e.
set by the suite's combinations file), but they will run with other engines.
If this is done, it is important to close keep track of this, so that
the include is removed once the bug is fixed. Doing it this way is not
as visible as an entry in disabled.def, so I'm fine with keeping your
solution and considering this alternative for later if necessary.
--
John
Hakan Kuecuekyilmaz wrote:
> #At file:///home/hakan/work/mysql/mysql-6.0-falcon/ based on
> revid:hky@stripped
>
> 2918 Hakan Kuecuekyilmaz 2008-11-18
> Disabled tests, which are failing on
> big-endian machines.
> added:
> mysql-test/suite/backup_engines/t/disabled.def
> modified:
> mysql-test/suite/backup/t/disabled.def
(...)
> === added file 'mysql-test/suite/backup_engines/t/disabled.def'
> --- a/mysql-test/suite/backup_engines/t/disabled.def 1970-01-01 00:00:00 +0000
> +++ b/mysql-test/suite/backup_engines/t/disabled.def 2008-11-18 21:10:05 +0000
> @@ -0,0 +1,13 @@
> +##############################################################################
> +#
> +# List the test cases that are to be disabled temporarily.
> +#
> +# Separate the test case name and the comment with ':'.
> +#
> +# <testcasename> : BUG#<xxxx> <date disabled> <disabler>
> <comment>
> +#
> +# Do not use any TAB characters for whitespace.
> +#
> +##############################################################################
> +backup_ptr_mixed : Bug#37281 2008-11-18 hakank Dates in Falcon on big-endian
> have wrong result.
> +backup_ptr_row : Bug#37281 2008-11-18 hakank Dates in Falcon on big-endian
> have wrong result.
