bzr commit into mysql-6.0 branch (kristofer.pettersson:2923)

[Kristofer Pettersson]

#At file:///home/thek/Development/cpp/mysqlbzr/mysql-6.0-bugteam/

 2923 Kristofer Pettersson	2008-11-17 [merge]
      Merge 5.1-bugteam -> 6.0-bugteam
modified:
  sql/sql_class.cc

=== modified file 'sql/sql_class.cc'
--- a/sql/sql_class.cc	2008-11-07 14:04:18 +0000
+++ b/sql/sql_class.cc	2008-11-17 15:10:21 +0000
@@ -312,7 +312,7 @@ void thd_inc_row_count(THD *thd)
   Dumps a text description of a thread, its security context
   (user, host) and the current query.
 
-  @param thd current thread context
+  @param thd thread context
   @param buffer pointer to preferred result buffer
   @param length length of buffer
   @param max_query_len how many chars of query to copy (0 for all)
@@ -386,7 +386,17 @@ char *thd_security_context(THD *thd, cha
   }
   if (str.c_ptr_safe() == buffer)
     return buffer;
-  return thd->strmake(str.ptr(), str.length());
+
+  /*
+    We have to copy the new string to the destination buffer because the string
+    was reallocated to a larger buffer to be able to fit.
+  */
+  DBUG_ASSERT(buffer != NULL);
+  length= min(str.length(), length-1);
+  memcpy(buffer, str.c_ptr_quick(), length);
+  /* Make sure that the new string is null terminated */
+  buffer[length]= '\0';
+  return buffer;
 }
 
 /**