> -----Original Message-----
> From: Olav Sandstaa [mailto:olav@stripped]
> Sent: Sunday, November 16, 2008 12:31 PM
> To: commits@stripped
> Subject: bzr commit into mysql-6.0-falcon-team branch (olav:2917)
> Bug#39260
>
> #At file:///home/os136802/mysql/develop/repo/falcon-bug39260/
>
> 2917 Olav Sandstaa 2008-11-16
> Fix to bug#39260 Falcon should detect that it has been compiled
> without support for C++ exception
Hi Olav,
Basically ok.
I'd add something like
#if (defined(__GNUC__) && !defined (__EXCEPTIONS__)) || (defined (_MSVC_VER)
&& !defined (_CPPUNWIND))
#error need working exception support
#endif
at the start of ha_falcon.cpp. Preprocessor flags responsible for exception
support are well documented for GCC and MSVC compilers and thus I would not
expect these flags to change over time. Detection at earlier stage (compile
time) seems more efficient than detection at runtime for me. Runtime check
does not hurt and can be left in.
