Hi, Alfranio
I have only one comment about the commit message, see below, except
this, the patch is OK to push. Thank you for your work!
Alfranio Correia wrote:
> #At file:///home/acorreia/workspace.sun/playground.mysql/mysql-5.0.68-custom_build/
>
> 2704 Alfranio Correia 2008-11-13
> This is an update to BUG#40337 - Fsyncing master and relay log to disk after
> every event is too slow
>
I would suggest to state in the commment that this patch is an update
for BUG#35542 and BUG#31665, and is required for BUG#40337.
> Added option to sync master.info (--sync-master-info, integer) and relay log
> (--sync-relay-log, integer) to disk after every event and the relay info
> (--sync-relay-log-info, boolean) per transaction.
>
> This supersedes the patch proposed by Sinisa and modified by He Zhenxing to
> fix
> bugs: BUG#35542 and BUG#31665.
[snip]