Chuck Bell wrote:
> STATUS
> ------
> Patch approved pending acceptance and fulfillment of request.
>
> REQUESTS
> --------
> [1] The new test is not needed. Please update existing backup_logs_output
> test instead.
>
> COMMENTARY
> ----------
> [1] The new test adds another server restart to the test suite. We do not
> need the extra restart since we can use the existing backup_logs_output test
> and its option file to accomplish the same goal as the proposed test. We
> need to limit adding new tests particularly those that require a restart of
> the server. See below for details.
>
> SUGGESTIONS
> -----------
> None
>
> DETAILS
> -------
>> 2732 Jorgen Loland 2008-11-13
>> Bug#40282: --log-backup-output w/o argument sets
>> logging to wrong value
>>
>> Default value for --log-backup-output is TABLE. Before,
>> the option defaulted to FILE if specified without argument.
>> Now, it defaults to TABLE.
>> added:
>> mysql-test/suite/backup/r/backup_logs_output_emptyopt.result
>> mysql-test/suite/backup/t/backup_logs_output_emptyopt-master.opt
>> mysql-test/suite/backup/t/backup_logs_output_emptyopt.test
> ...
>
> [1] The extra test is not needed. The corrected patch should look like
> this...
(...)
> === modified file mysql-test/suite/backup/t/backup_logs_output-master.opt
> --- mysql-test/suite/backup/t/backup_logs_output-master.opt 2008-11-11
> 08:37:27 +0000
> +++ mysql-test/suite/backup/t/backup_logs_output-master.opt 2008-11-13
> 16:29:08 +0000
> @@ -1,1 +1,1 @@
> ---backup_history_log_file=$MYSQLTEST_VARDIR/master-data/history.txt
> --backup_progress_log_file=$MYSQLTEST_VARDIR/master-data/progress.txt
> --log-backup-output=FILE
> +--backup_history_log_file=$MYSQLTEST_VARDIR/master-data/history.txt
> --backup_progress_log_file=$MYSQLTEST_VARDIR/master-data/progress.txt
> --log-backup-output
I agree that this will test the patch, but doing so will also remove the
current test where the option HAS an argument. I did consider this
option, but was unsure if it was acceptable and therefore did the safest
thing.
--
Jørgen Løland
