STATUS
------
Patch approved pending acceptance and fulfillment of request.
REQUESTS
--------
[1] The new test is not needed. Please update existing backup_logs_output
test instead.
COMMENTARY
----------
[1] The new test adds another server restart to the test suite. We do not
need the extra restart since we can use the existing backup_logs_output test
and its option file to accomplish the same goal as the proposed test. We
need to limit adding new tests particularly those that require a restart of
the server. See below for details.
SUGGESTIONS
-----------
None
DETAILS
-------
> 2732 Jorgen Loland 2008-11-13
> Bug#40282: --log-backup-output w/o argument sets
> logging to wrong value
>
> Default value for --log-backup-output is TABLE. Before,
> the option defaulted to FILE if specified without argument.
> Now, it defaults to TABLE.
> added:
> mysql-test/suite/backup/r/backup_logs_output_emptyopt.result
> mysql-test/suite/backup/t/backup_logs_output_emptyopt-master.opt
> mysql-test/suite/backup/t/backup_logs_output_emptyopt.test
...
[1] The extra test is not needed. The corrected patch should look like
this...
=== modified file mysql-test/suite/backup/r/backup_logs_output.result
--- mysql-test/suite/backup/r/backup_logs_output.result 2008-11-10 16:49:10
+0000
+++ mysql-test/suite/backup/r/backup_logs_output.result 2008-11-13 16:32:20
+0000
@@ -13,7 +13,7 @@
backup_progress_log_file MYSQLTEST_VARDIR/master-data/progress.txt
SHOW VARIABLES LIKE 'log_backup_output';
Variable_name Value
-log_backup_output FILE
+log_backup_output TABLE
Set the backup log file names to default values.
SET @@global.backup_history_log_file = DEFAULT;
SET @@global.backup_progress_log_file = DEFAULT;
=== modified file mysql-test/suite/backup/t/backup_logs_output-master.opt
--- mysql-test/suite/backup/t/backup_logs_output-master.opt 2008-11-11
08:37:27 +0000
+++ mysql-test/suite/backup/t/backup_logs_output-master.opt 2008-11-13
16:29:08 +0000
@@ -1,1 +1,1 @@
---backup_history_log_file=$MYSQLTEST_VARDIR/master-data/history.txt
--backup_progress_log_file=$MYSQLTEST_VARDIR/master-data/progress.txt
--log-backup-output=FILE
+--backup_history_log_file=$MYSQLTEST_VARDIR/master-data/history.txt
--backup_progress_log_file=$MYSQLTEST_VARDIR/master-data/progress.txt
--log-backup-output
=== modified file sql/mysqld.cc
--- sql/mysqld.cc 2008-11-10 16:49:10 +0000
+++ sql/mysqld.cc 2008-11-13 16:31:45 +0000
@@ -8284,7 +8284,7 @@
{
if (!argument || !argument[0])
{
- log_backup_output_options= LOG_FILE;
+ log_backup_output_options= LOG_TABLE;
log_backup_output_str= log_output_typelib.type_names[1];
}
else
...
Chuck
