Re: bzr commit into mysql-5.0-bugteam branch (gshchepa:2711) Bug#40021

[Ingo Strüwing]

Hi Gleb,

ok to push by me. Please consider the below question/suggestion.

Gleb Shchepa, 10.11.2008 18:53:
...
>  2711 Gleb Shchepa	2008-11-10
>       Bug #40021: Renaming view fails, archived .frm for view is
>                   missing after downgrade
...
> @@ -716,9 +714,6 @@ static File_option view_parameters[]=
>   {{(char*) STRING_WITH_LEN("with_check_option")},
>    my_offsetof(TABLE_LIST, with_check),
>    FILE_OPTIONS_ULONGLONG},
> - {{(char*) STRING_WITH_LEN("revision")},
> -  my_offsetof(TABLE_LIST, revision),
> -  FILE_OPTIONS_REV},

As we are at eliminating the views revisions feature, won't it be good
to also remove FILE_OPTIONS_REV and 'old_version' handling of
write_parameter() altogether?

...

Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring   HRB München 161028