List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:November 12 2008 12:30pm
Subject:Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2721)
Bug#40303 Bug#40304
View as plain text  
Hi Chuck,

Thanks for looking at this. I have updated the patch to match the current backup 
tree <http://lists.mysql.com/commits/58536>.

Chuck Bell wrote:
> I think the error message needs rewriting.
> -from-
>   eng "Could not create validity point of the image"
> -to-
>   eng "Could not create the validity point for the backup image file"
> -or-
>   eng "Could not create the validity point for backup"
> 

I have changed it to "Could not create the validity point". Phrase "for backup" 
is neither needed nor really correct -- IMO the validity point is not a property 
of "the backup" but rather of the backup image created. Anyway, we don't need it 
because the message is seen in context of backup operation. Compare:

sql> BACKUP ... TO ....;
ERROR: Could not create the validity point for backup.

and

sql> BACKUP ... TO ....;
ERROR: Could not create the validity point.

The user knows that the error message is related to the BACKUP command he just 
issued.

Rafal
Thread
bzr commit into mysql-6.0-backup branch (Rafal.Somla:2721) Bug#40303Bug#40304Rafal Somla5 Nov
  • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2721)Bug#40303 Bug#40304Chuck Bell5 Nov
    • Re: bzr commit into mysql-6.0-backup branch (Rafal.Somla:2721)Bug#40303 Bug#40304Rafal Somla12 Nov