List:Commits« Previous MessageNext Message »
From:He Zhenxing Date:November 12 2008 7:31am
Subject:Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)
Bug#31665 Bug#35542 Bug#40337
View as plain text  
alfranio correia wrote:
> He Zhenxing wrote:
> 
> Sorry for the delayed answer.
> 
> See the in-line comment.
> 
> Thanks.
> 
> > Hi Alfranio
> >
> > Nice work, just one comment, why not make option --sync-relay-log-info
> > act the same way as the others, I mean sync relay log every #th
> > transactions instead of every transaction? I think this will make all
> > these options more consistent, and users may not want to sync relay log
> > info for every transaction if they have a lots of small transactions.
> >   
> 
> I thought about that...  though.
> In the future, this information will be written atomically within the
> context of a transaction, thus introducing a future that will be removed
> in the future is not a good idea.
> 

Sorry, I don't quite understand your comment, what information that will
be written within the context of a transaction?

What I am thinking is that option --sync-relay-log-info is treated as a
boolean in your patch, it will enable sync relay-log.info for EVERY
transaction. While for option --sync-relay-log, it is used as a counter
too, and it will sync relay-log for EVERY #TH transactions.

> what do you think?



[ snip ]

Thread
bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704) Bug#31665Bug#35542 Bug#40337Alfranio Correia29 Oct
  • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704) Bug#31665 Bug#35542 Bug#40337Andrei Elkin30 Oct
  • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)Bug#31665 Bug#35542 Bug#40337He Zhenxing3 Nov
    • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)Bug#31665 Bug#35542 Bug#40337alfranio correia12 Nov
      • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)Bug#31665 Bug#35542 Bug#40337He Zhenxing12 Nov
  • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)Bug#31665 Bug#35542 Bug#40337Mats Kindahl6 Nov
    • Re: bzr commit into mysql-5.0-bugteam branch (alfranio.correia:2704)Bug#31665 Bug#35542 Bug#40337alfranio correia7 Nov