List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:November 6 2008 7:16pm
Subject:RE: bzr commit into mysql-6.0-falcon-team branch (vvaintroub:2905)
Bug#39789
View as plain text  
> -----Original Message-----
> From: Kevin.Lewis@stripped [mailto:Kevin.Lewis@stripped]
> Sent: Thursday, November 06, 2008 7:53 PM
> To: Vladislav Vaintroub
> Cc: commits@stripped
> Subject: Re: bzr commit into mysql-6.0-falcon-team branch
> (vvaintroub:2905) Bug#39789
> 
> Vlad,
> 
> Code looks good to me.  But I have one question.  if you get a
> TABLESPACE_NOT_EXIST_ERROR in pass 1 of SerialLog::recover () thown by
> SRLUpdateRecords::pass1().  Are you sure it should be thrown?  or
> should
> it be ignored and continue with Pass 1?
> 
> 
Kevin, the exception TABLESPACE_NOT_EXIST_ERROR is not thrown from
SRLUpdateRecords::pass1().
It is ignored,
> +				if (e.getSqlcode() !=
TABLESPACE_NOT_EXIST_ERROR)
> +					throw;

any other exception not ignored (whereby there is much probably no other
exception possible)



Thread
bzr commit into mysql-6.0-falcon-team branch (vvaintroub:2905)Bug#39789Vladislav Vaintroub6 Nov
RE: bzr commit into mysql-6.0-falcon-team branch (vvaintroub:2905)Bug#39789Vladislav Vaintroub6 Nov