List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:November 6 2008 3:51pm
Subject:Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)
Bug#38133
View as plain text  
Hi Vlad,

Vladislav Vaintroub, 06.11.2008 16:31:
...
> The current coding style
> http://forge.mysql.com/wiki/MySQL_Internals_Coding_Guidelines  states
> Do not use the %p marker of printf() (fprintf(), vprintf(), etc) because it
> leads to different outputs (for example on some Linux and Mac OS X the
> output starts with 0x while it does not on some Solaris). In MySQL 6.0 and
> later, use my_vsnprintf, DBUG_PRINT with %p for pointer formatting
> consistent across different platforms.In earlier versions, use printf-family
> functions with 0x%lx, but beware it truncates pointers on 64-bit Windows.
> Being sure that there is always 0x enables us to quickly identify pointer
> values in the DBUG trace.

Thanks for the information. I must have missed the announcement.

Regards
Ingo
-- 
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring   HRB München 161028
Thread
bzr commit into mysql-6.0-backup branch (ingo.struewing:2672) Bug#38133Ingo Struewing23 Jul
  • RE: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672) Bug#38133Chuck Bell29 Jul
  • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Guilhem Bichot6 Nov
    • RE: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Vladislav Vaintroub6 Nov
    • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Ingo Strüwing6 Nov
      • RE: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Vladislav Vaintroub6 Nov
        • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Ingo Strüwing6 Nov
      • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672)Bug#38133Guilhem Bichot6 Nov
        • New patch available [Re: bzr commit into mysql-6.0-backup branch(ingo.struewing:2672) Bug#38133]Ingo Strüwing13 Nov