STATUS
======
Not approved, test failure.
Code changes looks good.
REQUESTS
========
I get the following test diff. I guess you have forgotten to add an
option file.
@@ -3,14 +3,14 @@
SHOW VARIABLES LIKE 'backup_history%';
Variable_name Value
backup_history_log ON
-backup_history_log_file MYSQLTEST_VARDIR/master-data/history.txt
+backup_history_log_file MYSQLTEST_VARDIR/master-data/backup_history.log
SHOW VARIABLES LIKE 'backup_progress%';
Variable_name Value
backup_progress_log ON
-backup_progress_log_file MYSQLTEST_VARDIR/master-data/progress.txt
+backup_progress_log_file MYSQLTEST_VARDIR/master-data/backup_progress.log
SHOW VARIABLES LIKE 'log_backup_output';
Variable_name Value
-log_backup_output FILE
+log_backup_output TABLE
Set the backup log file names to default values.
SET @@global.backup_history_log_file = DEFAULT;
SET @@global.backup_progress_log_file = DEFAULT;
SUGGESTIONS
===========
I suggest "to given file" instead of "to a given file" (also consistent
with existing wording for similar variables):
> + "Log backup history to a given file.",
> + "Log backup progress to a given file.",
