Rafal,
I was trying to get ahead of my reviews and started looking at this. I
have a request before I begin reviewing in earnest. Note: This isn't a
review, just a prelude request so that I can conduct the review.
Request: Please update your tree and reissue the patch.
Reasons: The patch does not apply correctly to the current tree. The
following files contain rejects:
* backup_errors.result (not worried about this one)
* errmsg.txt (always happens -- not a big deal either)
* data_backup.cc
- has conflicts WRT commit blocker. I am concerned about this.
* kernel.cc
- has conflicts WRT open tables portion. Tree uses open..derived and
your patch is based on the older code. I am concerned about this.
I fixed these issues manually and compiled the code. I ran the test
suites and had got some strange results (see attached) which may not be
related but I thought you might want to see them nonetheless. I have not
seen these results until I ran with this patch.
(minor) Suggestion (since you have to resubmit the patch anyway):
I think the error message needs rewriting.
-from-
eng "Could not create validity point of the image"
-to-
eng "Could not create the validity point for the backup image file"
-or-
eng "Could not create the validity point for backup"
Chuck
Rafal Somla wrote:
> #At file:///ext/mysql/bzr/backup/bug40303/
>
> 2721 Rafal Somla 2008-11-05
> BUG#40303 (Backup: Wrong error send to client if several errors reported)
> BUG#40304 (Backup: Errors reported during BACKUP show as warnings on the
> error stack)
>
> Before: Errors reported using backup::Logger class could be saved and in
> case several errors are reported, the last one was sent to client as an
> error reply from BACKUP/RESTORE command.
>
> After: Errors reported with backup::Logger are reported to the server
> using my_printf_error(..) function. This function pushes error on the
> error stack (unles told otherwise) and stores the first reported error
> so that it is send to the client.
>
> Additionally.
>
> - Function log_error(..) is moved to the Logger class.
>
> - Code is changed do consistently use Logger::report/log_error() for error
> reporting.
>
> - Semantics of Backup_restore_ctx::fatal_error() has been changed to
> discourage its use as an error reporting facility. Now it is an internal helper
>
> method which moves the context object into error state. It is used only by the
>
> class methods and it is made private. The idea is that context object should
> move into error state only as a result of executing one of its methods (not
> externally).
>
> - Improved error reporting in few places.
Logging: ./mysql-test-run.pl --do-test=backup --suite=backup,backup_engines --force
MySQL Version 6.0.8
Using dynamic switching of binlog format
Skipping ndbcluster, mysqld not compiled with ndbcluster
Setting mysqld to support SSL connections
Binaries are debug compiled
Using MTR_BUILD_THREAD = 0
Using MASTER_MYPORT = 9306
Using MASTER_MYPORT1 = 9307
Using SLAVE_MYPORT = 9308
Using SLAVE_MYPORT1 = 9309
Using SLAVE_MYPORT2 = 9310
- adding combinations
Killing Possible Leftover Processes
Removing Stale Files
Creating Directories
Installing Master Database
Saving snapshot of installed databases
=======================================================
TEST RESULT TIME (ms)
-------------------------------------------------------
backup.backup [ pass ] 4446
backup.backup_backupdir [ pass ] 998
backup.backup_blob [ pass ] 967
backup.backup_charsets [ pass ] 281
backup.backup_commit_backup [ skipped ] Test needs the Falcon storage engine
backup.backup_commit_blocker [ pass ] 1303
backup.backup_commit_restore [ skipped ] Test needs the Falcon storage engine
backup.backup_compression [ pass ] 624
backup.backup_concurrent [ pass ] 562
backup.backup_db_grants [ pass ] 951
backup.backup_ddl_blocker [ disabled ] Bug#17823 2008-10-09 rafal Tests in main
suite leave undeleted files causing this test to fail
backup.backup_default [ skipped ] Test needs the Falcon storage engine
backup.backup_errors [ pass ] 1607
backup.backup_fkey [ pass ] 920
backup.backup_lock_myisam [ pass ] 3925
backup.backup_logs [ pass ] 1451
backup.backup_logs_output [ pass ] 1654
backup.backup_logs_purge [ pass ] 11029
backup.backup_many_dbs [ pass ] 3978
backup.backup_multi_blocks [ pass ] 312
backup.backup_myisam1 [ pass ] 250
backup.backup_myisam2 [ pass ] 670
backup.backup_no_be [ disabled ] Bug#38023 2008-07-16 rafal Test triggers
valgrind warnings described in the bug
backup.backup_no_data [ disabled ] Bug#17823 2008-10-09 rafal Tests in main
suite leave undeleted files causing this test to fail
backup.backup_no_engine [ disabled ] Bug#36021 2008-04-13 rsomla server crashes
when openning table with unknown storage engine
backup.backup_nodata_driver [ fail ]
mysqltest: At line 130: query 'RESTORE FROM 'bup_nodata.bak'' failed: 1146: Table
'bup_data.myisam1' doesn't exist
The result from queries just before the failure was:
< snip >
Period Vapor_period
DROP DATABASE bup_data;
show data
SHOW FULL TABLES FROM bup_nodata;
Tables_in_bup_nodata Table_type
b1 BASE TABLE
e1 BASE TABLE
f1 BASE TABLE
merge1 BASE TABLE
SELECT * FROM bup_nodata.merge1;
ERROR 42S02: Table 'bup_data.myisam1' doesn't exist
SELECT * FROM bup_nodata.f1;
Got one of the listed errors
SELECT * FROM bup_nodata.b1;
a b c
SELECT * FROM bup_nodata.e1;
Period Vapor_period
DROP DATABASE bup_nodata;
Restoring nodata database.
RESTORE FROM 'bup_nodata.bak';
More results from queries before failure can be found in
d:\source\bzr\mysql-6.0-bug-40304\mysql-test\var\log\backup_nodata_driver.log
Warnings from just before the error:
Error 1146 Table 'bup_data.myisam1' doesn't exist
Stopping All Servers
Restoring snapshot of databases
Resuming Tests
backup.backup_objects [ pass ] 1406
backup.backup_procedures [ pass ] 234
backup.backup_securefilepriv [ pass ] 1011
backup.backup_security [ pass ] 515
backup.backup_snapshot [ pass ] 640
backup.backup_tablespace [ skipped ] Test needs the Falcon storage engine
backup.backup_timeout [ pass ] 1482
backup.backup_triggers_and_events [ disabled ] Bug#37762 2008-07-01 rafal Test fails on
remove_file for unknown reasons
backup.backup_views [ pass ] 3105
backup_engines.backup_functions 'myisam' [ pass ] 1139
backup_engines.backup_online_testing 'myisam' [ pass ] 2792
backup_engines.backup_procedures 'myisam' [ pass ] 546
backup_engines.backup_ptr_commit_mixed 'myisam' [ skipped ] "This test does not support
Myisam engine"
backup_engines.backup_ptr_commit_row 'myisam' [ skipped ] "This test does not support
Myisam engine"
backup_engines.backup_ptr_commit_stmt 'myisam' [ skipped ] "This test does not support
Myisam engine"
backup_engines.backup_ptr_mixed 'myisam' [ pass ] 6505
backup_engines.backup_ptr_objects_mixed 'myisam' [ fail ]
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 00392CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 00392350, allocated at line 201 in '..\mysys\my_alloc.c'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 00172CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 00172350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 018130E0, allocated at line 155 in '.\readline.cc'
36 bytes at 00282738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 01942CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 01942350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 00C830E0, allocated at line 155 in '.\readline.cc'
36 bytes at 00192738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 01B52CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 01B52350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019430E0, allocated at line 155 in '.\readline.cc'
36 bytes at 018E2738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 4
Warning: Memory that was not free'ed (600 bytes):
104 bytes at 01A02DB8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
20 bytes at 01A025C0, allocated at line 638 in '..\mysys\my_getopt.c'
20 bytes at 01A02560, allocated at line 638 in '..\mysys\my_getopt.c'
456 bytes at 01A02350, allocated at line 201 in '..\mysys\my_alloc.c'
ERROR 7 (HY000) at line 207: Error on rename of '.\ptr_ob1\t1.TRG~' to '.\ptr_ob1\t1.TRG'
(Errcode: 17)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 018130E0, allocated at line 155 in '.\readline.cc'
36 bytes at 001C2738, allocated at line 34 in '.\readline.cc'
mysqltest: In included file ".\suite\backup_engines\include\backup_ptr_objects.inc": At
line 463: command "$MYSQL_BINLOG --start-datetime="2010-01-21 15:32:22"
--stop-datetime="2010-01-21 15:32:24" $MYSQLTEST_VARDIR/log/master-bin.000001 |$MYSQL"
failed
The result from queries just before the failure was:
< snip >
6
15
7
33
SELECT * FROM ptr_ob1.t11;
i sr
1 2
10 5
11 12
SELECT ptr_ob1.f1();
ptr_ob1.f1()
8
DROP DATABASE ptr_ob1;
DROP DATABASE ptr_ob2;
*** TEST3 *** :
This test will recover data and objects using binlog dates
till point of backup and after backup.
Use mysqlbinlog dates to recover data till point of backup.
exec of 'd:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysqlbinlog.exe --no-defaults
--disable-force-if-open --debug-check
--character-sets-dir=d:/source/bzr/mysql-6.0-bug-40304/sql/share/charsets
--start-datetime="2010-01-21 15:32:22" --stop-datetime="2010-01-21 15:32:24"
d:/source/bzr/mysql-6.0-bug-40304/mysql-test/var/log/master-bin.000001
|d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe --no-defaults --debug-check
--host=localhost --user=root --password= --port=9306
--socket=d:/source/bzr/mysql-6.0-bug-40304/mysql-test/var/tmp/master.sock
--character-sets-dir=d:/source/bzr/mysql-6.0-bug-40304/sql/share/charsets' failed, error:
1, status: 1, errno: 0
More results from queries before failure can be found in
d:\source\bzr\mysql-6.0-bug-40304\mysql-test\var\log\backup_ptr_objects_mixed.log
Stopping All Servers
Restoring snapshot of databases
Resuming Tests
backup_engines.backup_ptr_objects_row 'myisam' [ pass ] 7878
backup_engines.backup_ptr_objects_stmt 'myisam' [ pass ] 7878
backup_engines.backup_ptr_row 'myisam' [ pass ] 4540
backup_engines.backup_ptr_stmt 'myisam' [ pass ] 4758
backup_engines.backup_tmp_tables 'myisam' [ pass ] 421
backup_engines.backup_triggers 'myisam' [ pass ] 1872
backup_engines.backup_functions 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_online_testing 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_procedures 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_commit_mixed 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_commit_row 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_commit_stmt 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_mixed 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_objects_mixed 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_objects_row 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_objects_stmt 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_row 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_ptr_stmt 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_tmp_tables 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_triggers 'falcon' [ skipped ] 'falcon' not supported
backup_engines.backup_functions 'memory' [ pass ] 734
backup_engines.backup_online_testing 'memory' [ pass ] 2808
backup_engines.backup_procedures 'memory' [ pass ] 531
backup_engines.backup_ptr_commit_mixed 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_commit_row 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_commit_stmt 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_mixed 'memory' [ skipped ] "This test does not support memory
engine"
backup_engines.backup_ptr_objects_mixed 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_objects_row 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_objects_stmt 'memory' [ skipped ] "This test does not support
memory engine"
backup_engines.backup_ptr_row 'memory' [ skipped ] "This test does not support memory
engine"
backup_engines.backup_ptr_stmt 'memory' [ skipped ] "This test does not support memory
engine"
backup_engines.backup_tmp_tables 'memory' [ pass ] 390
backup_engines.backup_triggers 'memory' [ pass ] 1263
backup_engines.backup_functions 'innodb' [ pass ] 967
backup_engines.backup_online_testing 'innodb' [ pass ] 2792
backup_engines.backup_procedures 'innodb' [ pass ] 577
backup_engines.backup_ptr_commit_mixed 'innodb' [ pass ] 1982
backup_engines.backup_ptr_commit_row 'innodb' [ pass ] 2121
backup_engines.backup_ptr_commit_stmt 'innodb' [ pass ] 1825
backup_engines.backup_ptr_mixed 'innodb' [ pass ] 4555
backup_engines.backup_ptr_objects_mixed 'innodb' [ skipped ] "This test does not support
Innodb engine"
backup_engines.backup_ptr_objects_row 'innodb' [ fail ]
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 00BD2CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 00BD2350, allocated at line 201 in '..\mysys\my_alloc.c'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 01912CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 01912350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 01A930E0, allocated at line 155 in '.\readline.cc'
36 bytes at 01A62738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 00152CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 00152350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 00CC30E0, allocated at line 155 in '.\readline.cc'
36 bytes at 00E22738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 01B72CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 01B72350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019330E0, allocated at line 155 in '.\readline.cc'
36 bytes at 01AC2738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 4
Warning: Memory that was not free'ed (600 bytes):
104 bytes at 00DE2DB8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
20 bytes at 00DE25C0, allocated at line 638 in '..\mysys\my_getopt.c'
20 bytes at 00DE2560, allocated at line 638 in '..\mysys\my_getopt.c'
456 bytes at 00DE2350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019A30E0, allocated at line 155 in '.\readline.cc'
36 bytes at 01B22738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 4
Warning: Memory that was not free'ed (600 bytes):
104 bytes at 01932DB8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
20 bytes at 019325C0, allocated at line 638 in '..\mysys\my_getopt.c'
20 bytes at 01932560, allocated at line 638 in '..\mysys\my_getopt.c'
456 bytes at 01932350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019530E0, allocated at line 155 in '.\readline.cc'
36 bytes at 003F2738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 4
Warning: Memory that was not free'ed (600 bytes):
104 bytes at 001B2DB8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
20 bytes at 001B25C0, allocated at line 638 in '..\mysys\my_getopt.c'
20 bytes at 001B2560, allocated at line 638 in '..\mysys\my_getopt.c'
456 bytes at 001B2350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019130E0, allocated at line 155 in '.\readline.cc'
36 bytes at 01AA2738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (560 bytes):
104 bytes at 01C02CF8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
456 bytes at 01C02350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 019330E0, allocated at line 155 in '.\readline.cc'
36 bytes at 01BD2738, allocated at line 34 in '.\readline.cc'
Warning: Not freed memory segments: 4
Warning: Memory that was not free'ed (600 bytes):
104 bytes at 01972DB8, allocated at line 1020 in
'D:\source\bzr\mysql-6.0-bug-40304\sql\log_event.cc'
20 bytes at 019725C0, allocated at line 638 in '..\mysys\my_getopt.c'
20 bytes at 01972560, allocated at line 638 in '..\mysys\my_getopt.c'
456 bytes at 01972350, allocated at line 201 in '..\mysys\my_alloc.c'
d:\source\bzr\mysql-6.0-bug-40304\client\debug\\mysql.exe: Error reading file '(null)'
(Errcode: 32)
Warning: Not freed memory segments: 2
Warning: Memory that was not free'ed (8229 bytes):
8193 bytes at 00B030E0, allocated at line 155 in '.\readline.cc'
36 bytes at 003B2738, allocated at line 34 in '.\readline.cc'
---
d:/source/bzr/mysql-6.0-bug-40304/mysql-test/suite/backup_engines/r/backup_ptr_objects_row.result 2008-11-05
22:40:49.866783400 +0300
+++
d:\source\bzr\mysql-6.0-bug-40304\mysql-test\suite\backup_engines\r\backup_ptr_objects_row.reject 2008-11-06
00:00:45.648983400 +0300
@@ -175,7 +175,7 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
+8 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.v1;
id b
11 set1
@@ -242,9 +242,9 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
+8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -273,10 +273,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
CALL ptr_ob2.p4();
id
1
@@ -369,10 +369,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -510,12 +510,12 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -548,13 +548,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
CALL ptr_ob2.p4();
id
1
@@ -658,13 +658,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -799,10 +799,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -923,13 +923,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1069,10 +1069,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1193,13 +1193,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1336,10 +1336,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1460,13 +1460,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1606,10 +1606,10 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
+9 Trigger fired from procedure p2
+10 Trigger fired from procedure p2
+11 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1730,13 +1730,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -1875,13 +1875,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
@@ -2020,13 +2020,13 @@
2 Normal Insert2
3 Normal Insert3
4 Normal Insert4
-5 Trigger fired from after update of ptr_ob2.t1
-6 Trigger fired from procedure p2
-7 Trigger fired from procedure p2
8 Trigger fired from after update of ptr_ob2.t1
-9 Insert after backup
+9 Trigger fired from procedure p2
10 Trigger fired from procedure p2
11 Trigger fired from after update of ptr_ob2.t1
+12 Insert after backup
+13 Trigger fired from procedure p2
+14 Trigger fired from after update of ptr_ob2.t1
SELECT * FROM ptr_ob1.t3;
srno name old_a
1 t1 20
mysqltest: Result content mismatch
Stopping All Servers
Restoring snapshot of databases
Resuming Tests
backup_engines.backup_ptr_objects_stmt 'innodb' [ skipped ] "This test does not support
Innodb engine"
backup_engines.backup_ptr_row 'innodb' [ pass ] 4524
backup_engines.backup_ptr_stmt 'innodb' [ pass ] 4758
backup_engines.backup_tmp_tables 'innodb' [ pass ] 390
backup_engines.backup_triggers 'innodb' [ pass ] 1545
-------------------------------------------------------
Stopping All Servers
Failed 3/54 tests, 94.44% were successful.
The log files in var/log may give you some hint
of what went wrong.
If you want to report this error, please read first the documentation at
http://dev.mysql.com/doc/mysql/en/mysql-test-suite.html
The servers were restarted 21 times
Spent 114.412 of 224 seconds executing testcases
mysql-test-run in default mode: *** Failing the test(s): backup.backup_nodata_driver
backup_engines.backup_ptr_objects_mixed backup_engines.backup_ptr_objects_row