From: Date: November 3 2008 4:02pm
Subject: Re: bzr commit into mysql-6.0-falcon-team branch (olav:2899)	Bug#40390
List-Archive: http://lists.mysql.com/commits/57697
Message-Id: <1225724536.19292.3.camel@lu0011>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

Ok to push. I am sure you tested the change already?

Best regards,

Hakan

On Mo, 2008-11-03 at 08:56 +0000, Olav Sandstaa wrote:
> #At file:///home/os136802/mysql/develop/repo/falcon-atomic/
> 
>  2899 Olav Sandstaa	2008-11-03
>       Move check of support for Solaris atomic operations from configure.in to falcon/plug.in (as suggested in
>       comment to bug#40390).
> modified:
>   configure.in
>   storage/falcon/plug.in
> 
> per-file messages:
>   configure.in
>     Move check of support for Solaris atomic operations from configure.in to falcon/plug.in.
>   storage/falcon/plug.in
>     Move check of support for Solaris atomic operations from configure.in to falcon/plug.in.
> === modified file 'configure.in'
> 
> === modified file 'configure.in'
> --- a/configure.in	2008-10-30 15:08:17 +0000
> +++ b/configure.in	2008-11-03 08:56:28 +0000
> @@ -1795,9 +1795,6 @@
>     *) AC_MSG_ERROR(["$with_atomic_ops" is not a valid value for --with-atomic-ops]) ;;
>  esac
>  
> -# Check if we have the atomic_* functions on Solaris
> -AC_CHECK_FUNC(atomic_cas_32, AC_DEFINE([HAVE_SOLARIS_ATOMIC], [1], [Define to 1 if Solaris support atomic functions.]))
> -
>  # Force static compilation to avoid linking problems/get more speed
>  AC_ARG_WITH(mysqld-ldflags,
>      [  --with-mysqld-ldflags   Extra linking arguments for mysqld],
> 
> === modified file 'storage/falcon/plug.in'
> --- a/storage/falcon/plug.in	2008-09-23 09:08:59 +0000
> +++ b/storage/falcon/plug.in	2008-11-03 08:56:28 +0000
> @@ -4,6 +4,9 @@
>  MYSQL_PLUGIN_STATIC(falcon,    [libfalcon.a])
>  MYSQL_PLUGIN_DYNAMIC(falcon,   [ha_falcon.la])
>  
> +# Check if we have the atomic_* functions on Solaris
> +AC_CHECK_FUNC(atomic_cas_32, AC_DEFINE([HAVE_SOLARIS_ATOMIC], [1], [Define to 1 if Solaris support atomic functions.]))
> +
>  # Check for supported machine types.
>  AC_CACHE_CHECK([if Falcon Storage Engine is supported on $MACHINE_TYPE],
>    			   falcon_supported_by_machine,[
> 
> 
-- 
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160 98953296
Sun Microsystems GmbH     Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer:  Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering   HRB MUC 161028     49.011, 8.376