List:Commits« Previous MessageNext Message »
From:Peter Gulutzan Date:October 29 2008 7:43pm
Subject:Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567
Bug#34480 Bug#36933
View as plain text  
Hi Rafal,

Rafal Somla wrote:
> Hi Peter,
> 
> Do you agree that silently ignoring duplicate database names in the
> database list passed to BACKUP command is an acceptable behaviour? E.g.,
> 
> sql> BACKUP DATABASE foo, bar, foo, bar TO 'image.bkp';
> 
> will simply backup databases `foo` and `bar`.
> 
> Rafal
> 
> Øystein Grøvlen wrote:
>>  - In Bug#33567, Peter says that "users wouldn't enter the same name
>>    twice except in error, so this should be an error."  Have you
>>    discussed your solution (to just ignore duplicates) with Peter?

Here's what I get with some other statements, where I repeat table name:

mysql> check table t2,t2;
ERROR 1066 (42000): Not unique table/alias: 't2'

mysql> repair local table t2,t2;
ERROR 1066 (42000): Not unique table/alias: 't2'

mysql> drop table t2,t2;
ERROR 1066 (42000): Not unique table/alias: 't2'

mysql> cache index t2,t2 in x;
ERROR 1066 (42000): Not unique table/alias: 't2'

It's harder to come up with an example that uses a database name.
And I can think of counter-examples with column names, e.g.
mysql> grant select (s1,s1) on t2 to joe;
Query OK, 0 rows affected (0.01 sec)
So I can say that an error is okay MySQL behaviour, but not always.

But I reject the careful wording of your question:
"Do you agree that ... is an acceptable behaviour?"
Maybe it's acceptable, but if the question were
"Which is right, to return an error or not return an error?"
I'd say "return an error". And that's the bug complaint.
Why won't you? Is the difficulty technical?

-- 

Peter Gulutzan
Database Group / MySQL www.mysql.com
Sun Microsystems of Canada Inc.
Edmonton, AB, Canada
Thread
bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567 Bug#34480Bug#36933Rafal Somla24 Oct
  • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Jørgen Løland24 Oct
  • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Øystein Grøvlen29 Oct
    • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Rafal Somla29 Oct
      • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Peter Gulutzan29 Oct
        • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Rafal Somla30 Oct
    • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Rafal Somla31 Oct
      • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Øystein Grøvlen31 Oct
        • Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567Bug#34480 Bug#36933Rafal Somla3 Nov