> One more comment to the code. It is about how you disable binlogging of
> backup logs writes. For all other types of logs existing in the server,
> e.g., the general log, this is done on the level of
> Log_to_csv_event_handler. For example see this code in
> Log_to_csv_event_handler::log_general(..) (log.cc:386):
> > save_thd_options= thd->options;
> > thd->options&= ~OPTION_BIN_LOG;
> I suggest that you do the same for the backup logs.
I have made this change. It does improve the code. Thanks for the
> Also, is it really sensible to use server services API from within the
> server core (as you do in log.cc)? The way I see it, the API interfaces
> server core to the external clients such as online backup module. Server
> core implements the API so it is strange if it also uses it, as it knows
> the internals and knows how to achieve given effect in a most direct and
> efficient way.
Agree as we discussed on IRC.