Hi Marc,
On 10/3/08 6:35 PM, Marc Alff wrote:
> #At file:///home/malff/BZR-TREE/mysql-6.0-wl2110-review/
>
> 2704 Marc Alff 2008-10-03
> WL#2110 (Stored Procedures: Implement SIGNAL)
> WL#2265 (Stored Procedures: Implement RESIGNAL)
> Bug#11661 (Raising Exceptions from within stored procedures: Support for
> SIGNAL statement)
>
> Fixed review comments related to memory management.
>
> - Changed all the handle_condition() methods to return a SQL_condition
> as *output*, instead of *input*.
> The logic now find first where the condition should be written to,
> and then the caller writes the extra attributes in place.
> This change removes the need for SQL_condition::deep_copy().
> Also, when a condition is dropped (Internal handlers, warn_list full),
> this saves some CPU cycle.
You still don't explain why this complexity is required. Why the old and
simpler way won't work?
Regards,
-- Davi
