In my opinion, we should keep the default most of the time but increase
it when a concurrent transaction happens.
This should be done to avoid failures.
Alfranio.
> Sven, Serge, hi.
>
>
>> Serge, Andrei,
>>
>> The test contains 16 places where it is expected to timeout, so the
>> timeout can't be 60 throughout the test (it would take 16 minutes to
>> execute). I suggest you set the timeout to something big as default, but
>> change it dynamically to 1 before each place where it expects a timeout.
>> The default value is 50 seconds, so I suggest to use that.
>>
>
> 50 secs is okay imo.
>
> cheers,
>
> Andrei
>
>
>> /Sven
>>
>>
>> Andrei Elkin wrote:
>>
>>> Sergei, hello.
>>>
>>> The patch is good.
>>> Still why not to set the value for timeout like 60 seconds that would
>>> practically guarantee the timeout never elapse.
>>> You would agree certainly that the bigger value normally does not slow down
> this
>>> test, and it is better to wait longer for the test to succeed instead
>>> of impatiently give up.
>>>
>>> So, let's make it 60 seconds, agreed?
>>>
>>> regards,
>>>
>>> Andrei
>>>
>>>
>>>
>>>
>>>> #At bzr+ssh://bk-internal.mysql.com/bzrroot/server/mysql-6.0-sea
>>>>
>>>> 2697 Serge Kozlov 2008-09-15
>>>> Bug#38070. Set innodb_lock_wait_timeout to 5 instead 1 because
>>>> lock wait timeout exceeded too often.
>>>> modified:
>>>> mysql-test/suite/rpl/t/disabled.def
>>>> mysql-test/suite/rpl/t/rpl_locktrans_innodb-master.opt
>>>> mysql-test/suite/rpl/t/rpl_locktrans_innodb-slave.opt
>>>>
>>>> === modified file 'mysql-test/suite/rpl/t/disabled.def'
>>>> --- a/mysql-test/suite/rpl/t/disabled.def 2008-09-07 00:58:02 +0000
>>>> +++ b/mysql-test/suite/rpl/t/disabled.def 2008-09-15 09:42:38 +0000
>>>> @@ -30,7 +30,6 @@ rpl_heartbeat : Bug#37714 2
>>>> rpl_idempotency : Bug#37767 2008-07-14 alik Disabled to make
> 6.0 greaner (the test fails too often)
>>>>
>>>> rpl_flushlog_loop : Bug#37733 2008-07-17 alik Disabled to make
> 6.0 greaner (the test fails too often)
>>>> -rpl_locktrans_innodb : Bug#37712 2008-07-17 alik Disabled to make
> 6.0 greaner (the test fails too often)
>>>> rpl_temporary_errors : Bug#36968 2008-07-17 alik Disabled to make
> 6.0 greaner (the test fails too often)
>>>> rpl_temporary : BUG#38269 2008-07-21 Sven valgrind error in
> pushbuild
>>>> rpl_flushlog_loop : BUG#37733 2008-07-23 Sven disabled in
> 5.1-bugteam. the bug has been fixed in 5.1-rpl: please re-enable when that gets pushed to
> main
>>>>
>>>> === modified file
> 'mysql-test/suite/rpl/t/rpl_locktrans_innodb-master.opt'
>>>> --- a/mysql-test/suite/rpl/t/rpl_locktrans_innodb-master.opt 2008-02-19
> 12:45:37 +0000
>>>> +++ b/mysql-test/suite/rpl/t/rpl_locktrans_innodb-master.opt 2008-09-15
> 09:42:38 +0000
>>>> @@ -1,4 +1,4 @@
>>>> ---innodb_lock_wait_timeout=1
>>>> +--innodb_lock_wait_timeout=5
>>>> --log=locktrans_master.log
>>>> --log-output=FILE
>>>>
>>>>
>>>> === modified file
> 'mysql-test/suite/rpl/t/rpl_locktrans_innodb-slave.opt'
>>>> --- a/mysql-test/suite/rpl/t/rpl_locktrans_innodb-slave.opt 2008-02-19
> 12:45:37 +0000
>>>> +++ b/mysql-test/suite/rpl/t/rpl_locktrans_innodb-slave.opt 2008-09-15
> 09:42:38 +0000
>>>> @@ -1,4 +1,4 @@
>>>> ---innodb_lock_wait_timeout=1
>>>> +--innodb_lock_wait_timeout=5
>>>> --log=locktrans_slave.log
>>>> --log-output=FILE
>>>>
>>>>
>>>>
>>>> --
>>>> MySQL Code Commits Mailing List
>>>> For list archives: http://lists.mysql.com/commits
>>>> To unsubscribe: http://lists.mysql.com/commits?unsub=1
>>>>
>>>
>
>
