List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:October 24 2008 4:29pm
Subject:Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224
View as plain text  
Follow-up to self:

Joerg Bruehe wrote:
> Hi !
> 
> He Zhenxing wrote:
>> 
>> [[...]]
>>  #ifdef HAVE_REPLICATION
>> -  static unsigned char transmit_mem[sizeof(Binlog_transmit_delegate)];
>> -  static unsigned char relay_io_mem[sizeof(Binlog_relay_IO_delegate)];
>> +  static unsigned long transmit_mem[sizeof(Binlog_transmit_delegate) /
> sizeof(unsigned long) + 1];
>> +  static unsigned int relay_io_mem[sizeof(Binlog_relay_IO_delegate)/
> sizeof(unsigned long) + 1];
> 
> That last line looks wrong:
> You calculate the number of "int" elements based on the size of "long" ?
> 

Saw the fix too late - it seems already corrected.
Sorry for the false alarm :-(


Jörg

-- 
Joerg Bruehe,  MySQL Build Team,
               Joerg.Bruehe@stripped   (+49 30) 417 01 487
Sun Microsystems GmbH,   Sonnenallee 1,   D-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering     Muenchen: HRB161028

Thread
bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224He Zhenxing23 Oct
  • Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224Joerg Bruehe24 Oct
    • Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224Joerg Bruehe24 Oct