List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:October 24 2008 4:22pm
Subject:Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224
View as plain text  
Hi !

He Zhenxing wrote:
> #At file:///media/sda3/work/mysql/bzrwork/b40244/6.0-alik/
> 
>  2739 He Zhenxing	2008-10-23
>       BUG#40224 Optimized build of mysqld crashes when built with Sun Studio on
> SPARC
>             
>       Fix a segmental fault problem caused by unaligned memory when 
>       built with optimization on SPARC 64
> modified:
>   sql/rpl_handler.cc
> 
> === modified file 'sql/rpl_handler.cc'
> --- a/sql/rpl_handler.cc	2008-09-23 15:06:18 +0000
> +++ b/sql/rpl_handler.cc	2008-10-23 12:50:02 +0000
> @@ -88,11 +88,11 @@ int get_user_var_str(const char *name, c
>  
>  int delegates_init()
>  {
> [[...]]
>  #ifdef HAVE_REPLICATION
> -  static unsigned char transmit_mem[sizeof(Binlog_transmit_delegate)];
> -  static unsigned char relay_io_mem[sizeof(Binlog_relay_IO_delegate)];
> +  static unsigned long transmit_mem[sizeof(Binlog_transmit_delegate) /
> sizeof(unsigned long) + 1];
> +  static unsigned int relay_io_mem[sizeof(Binlog_relay_IO_delegate)/ sizeof(unsigned
> long) + 1];

That last line looks wrong:
You calculate the number of "int" elements based on the size of "long" ?

>  #endif
>    
>    if (!(transaction_delegate= new (trans_mem) Trans_delegate)
> 
> 

Jörg


-- 
Joerg Bruehe,  MySQL Build Team,
               Joerg.Bruehe@stripped   (+49 30) 417 01 487
Sun Microsystems GmbH,   Sonnenallee 1,   D-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Haering     Muenchen: HRB161028

Thread
bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224He Zhenxing23 Oct
  • Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224Joerg Bruehe24 Oct
    • Re: bzr commit into mysql-6.0 branch (hezx:2739) Bug#40224Joerg Bruehe24 Oct