Re: bzr commit into mysql-6.0 branch (Rafal.Somla:2717) Bug#33567 Bug#34480 Bug#36933

[Jørgen Løland]

Rafal,

The patch looks good and can be pushed. I verified that the attached 
test crashes without the patch but not with the patch.

Requests:
---------
None

Suggestions:
------------
1. Break lines at 80 characters:

"# When backing up, include bup_default database twice in the list to 
check that BACKUP will ignore"

Rafal Somla wrote:
> #At file:///ext/mysql/bzr/backup/bug36933/
> 
>  2717 Rafal Somla	2008-10-24
>       BUG#36933, BUG#34480, BUG#33567 (Backup: snapshot error + crash if double
> backup)
>       
>       Before: When user specified the same database twice in the BACKUP DATABASE
> statement, 
>       it was included twice in the backup image. This lead to a host of problems.
>       
>       After: BACKUP DATABASE will ignore duplicates in the database list. Each
> database,
>       together with its objects, will be included only once in the produced backup
> image.
> modified:
>   mysql-test/suite/backup/r/backup.result
>   mysql-test/suite/backup/t/backup.test
>   sql/backup/backup_info.cc
>   sql/backup/image_info.cc
>   sql/backup/image_info.h
> 


-- 
Jørgen Løland