List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:October 23 2008 7:58pm
Subject:Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364
View as plain text  
Rafal,

> 2. Do not set share->is_log_table to FALSE for backup log tables - this 
> violates semantics of the flag. I suggest introducing a new flag for 
> your purpose (allowing deletion of rows in log tables).

That flag is put there to prohibit deletion of tables used as logs. If I 
add a new flag, I will have to make extensive modifications to the csv 
storage engine. I do not feel that it violates the semantics of the 
flag. What I have done is added a very simple exception rule to allow 
the restriction to be turned off by the logging code -- specifically, 
the backup logging code. All other logs will perform the same way they 
always have. I do not see the need to make extensive changes to the CSV 
storage engine to satisfy this request when the existing solution is 
much less invasive.

Chuck
Thread
bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell19 Oct
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Rafal Somla23 Oct
    • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell23 Oct
    • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell23 Oct
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Rafal Somla24 Oct
    • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell23 Oct
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Rafal Somla24 Oct
        • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell24 Oct
    • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell24 Oct
    • Re: bzr commit into mysql-6.0-backup branch (cbell:2712) Bug#33364Chuck Bell24 Oct