STATUS
------
Clarification requested. Patch approval pending explanation of suppressed
warning.
REQUESTS
--------
There are suppressed events as a result of this patch. Executing the test
case in the bug report after the patch shows the patch fixes the problem but
examination of warnings shows there are warnings that are not reported to
the user. Is this correct? If the warning is supposed to be suppressed, why
does SHOW WARNINGS display it?
...
mysql> restore from '26.bak';
+-----------+
| backup_id |
+-----------+
| 273 |
+-----------+
1 row in set (0.14 sec)
mysql> show warnings;
+-------+------+------------------------+
| Level | Code | Message |
+-------+------+------------------------+
| Note | 1305 | Event X does not exist |
+-------+------+------------------------+
1 row in set (0.00 sec)
COMMENTARY
----------
No other issues beyond first reviewer's remarks.
SUGGESTIONS
-----------
None
DETAILS
-------
> 2707 oystein.grovlen@stripped 2008-10-13
> BUG#38810 Backup: crash if trigger and event with same name
> Issue: Server crashes when restoring a backup image of
> a database
> with trigger and event with the same names.
> Cause: Dependency table is indexed by name. Hence,
> trigger is not added when
> event with same name has already been inserted.
> Fix: Add type id to the key for the dependency table.
> modified:
> mysql-test/suite/backup/r/backup_triggers_and_events.result
> mysql-test/suite/backup/t/backup_triggers_and_events.test
> sql/backup/backup_info.cc
> sql/backup/backup_info.h
>
> per-file messages:
> mysql-test/suite/backup/r/backup_triggers_and_events.result
> Rename one trigger to test name collisions with events.
> mysql-test/suite/backup/t/backup_triggers_and_events.test
> Rename one trigger to test name collisions with events.
> sql/backup/backup_info.cc
> Add type info to keys for the dependency table.
> sql/backup/backup_info.h
> Add type parameter to get_dep_node so it so that type
> info can be added to the
> Dep_node keys.
...
