Rafal,
Here is another patch for you to review. I made the change you requested and
I felt that your suggestion was a good addition and this is the proper time
to implement it. I deviated slightly from your exact suggestion but I think
you will agree it accomplishes the goal.
http://lists.mysql.com/commits/56297
Chuck
> REQUESTS
> --------
> 1. Remove parameter 'path' of Logger::init() which is no longer used.
>
> COMMENTARY
> ----------
> I will accept this patch but I think that the handling of
> backup paths should be implemented differently. I express it
> in form of a suggestion for your consideration.
>
> SUGGESTIONS
> -----------
> 1. Do not dynamically allocate memory in
> Backup_log::backup_file(...) since you know in advance the
> size of the buffer.
>
> 2. Do not do backup file path computations, access checking
> and related tasks in the backup::Stream class but outside, in
> the Backup_restore_ctx class which is the logical place for
> doing all necessary preparations for BACKUP/RESTORE operation.
>