List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:October 9 2008 11:22am
Subject:Re: bzr commit into mysql-5.1 branch (kristofer.pettersson:2768)
Bug#38551
View as plain text  
* Kristofer Pettersson <Kristofer.Pettersson@stripped> [08/10/09 15:12]:
>  2768 Kristofer Pettersson	2008-10-09
>       Bug#38551 query cache can still consume [very little] cpu time even when it is
> off.
>                   
>       When the query cache size is zero, all query cache functionallity should be
>       skipped.
>             
>       By checking query_cache_size before attempting to invalidate a table or
>       db we avoid grabbing the query cache mutex. If the rare cases the query cache
>       size would change so we get a false read the cache has either been cleared or
> modified:

What's worse, we'll fail to invalidate a query, since you added it
to ::invalidate().

Which is a potential semantical problem.

-- 
Thread
bzr commit into mysql-5.1 branch (kristofer.pettersson:2768) Bug#38551Kristofer Pettersson9 Oct
  • Re: bzr commit into mysql-5.1 branch (kristofer.pettersson:2768)Bug#38551Konstantin Osipov9 Oct