From: Date: October 8 2008 7:45pm
Subject: Connector/NET commit: r1432 - in branches/5.2: . MySql.Data/Provider/Source MySql.Data/Tests/Source
List-Archive: http://lists.mysql.com/commits/55797
X-Bug: 39728
Message-Id: <200810081745.m98HjWSH008009@bk-internal.mysql.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Modified:
   branches/5.2/CHANGES
   branches/5.2/MySql.Data/Provider/Source/MySqlConnectionStringBuilder.cs
   branches/5.2/MySql.Data/Tests/Source/ConnectionStringBuilder.cs
Log:
fixed bug #39728 by making MySqlConnectionStringBuilder.GetConnectionString an internal method.  It should not have been publicly available anyway.  It is used internally by the MySqlConnection.ConnectionString property

Modified: branches/5.2/CHANGES
===================================================================
--- branches/5.2/CHANGES	2008-10-02 15:50:09 UTC (rev 1431)
+++ branches/5.2/CHANGES	2008-10-08 17:45:32 UTC (rev 1432)
@@ -15,7 +15,9 @@
   work correctly with some older server versions (bug #39330)  
 - Defaulting max allowed packet to 1024 to account for the possible case where the
   value doesn't come in as a server variable  
-
+- fixed bug #39728 by making MySqlConnectionStringBuilder.GetConnectionString an internal method.
+  It should not have been publicly available anyway.  It is used internally by the 
+  MySqlConnection.ConnectionString property
   
 Version 5.2.3 - 8/14/08
 - Increased the speed of MySqlDataReader.GetOrdinal dramatically by using a couple

Modified: branches/5.2/MySql.Data/Provider/Source/MySqlConnectionStringBuilder.cs
===================================================================
--- branches/5.2/MySql.Data/Provider/Source/MySqlConnectionStringBuilder.cs	2008-10-02 15:50:09 UTC (rev 1431)
+++ branches/5.2/MySql.Data/Provider/Source/MySqlConnectionStringBuilder.cs	2008-10-08 17:45:32 UTC (rev 1432)
@@ -1015,7 +1015,7 @@
         /// stripping out the password info
         /// </summary>
         /// <returns></returns>
-        public string GetConnectionString(bool includePass)
+        internal string GetConnectionString(bool includePass)
         {
             if (includePass)
                 return originalConnectionString;

Modified: branches/5.2/MySql.Data/Tests/Source/ConnectionStringBuilder.cs
===================================================================
--- branches/5.2/MySql.Data/Tests/Source/ConnectionStringBuilder.cs	2008-10-02 15:50:09 UTC (rev 1431)
+++ branches/5.2/MySql.Data/Tests/Source/ConnectionStringBuilder.cs	2008-10-08 17:45:32 UTC (rev 1432)
@@ -103,7 +103,7 @@
             MySqlConnectionStringBuilder s = new MySqlConnectionStringBuilder();
             s["database"] = "test";
             s["database"] = "test2";
-            Assert.AreEqual("database=test2", s.GetConnectionString(false));
+            Assert.AreEqual("database=test2", s.ConnectionString);
         }
     }
 }