List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:October 8 2008 7:53am
Subject:bzr commit into mysql-5.1 branch (stewart:2946)
View as plain text  
#At file:///C:/cygwin/home/stewart/mysql/win-ndbwin32/

 2946 Stewart Smith	2008-10-08
       use correct time for row count in select_count (ndb_select_count).
      
      Quite possibly a real bug if table has > 2billion rows.
modified:
  storage/ndb/tools/select_count.cpp

=== modified file 'storage/ndb/tools/select_count.cpp'
--- a/storage/ndb/tools/select_count.cpp	2008-08-21 06:31:25 +0000
+++ b/storage/ndb/tools/select_count.cpp	2008-10-08 08:43:17 +0000
@@ -28,7 +28,7 @@
 static int 
 select_count(Ndb* pNdb, const NdbDictionary::Table* pTab,
 	     int parallelism,
-	     int* count_rows,
+	     Uint64* count_rows,
 	     NdbOperation::LockMode lock);
 
 static const char* _dbname = "TEST_DB";
@@ -105,7 +105,7 @@ int main(int argc, char** argv){
       continue;
     }
 
-    int rows = 0;
+    Uint64 rows = 0;
     if (select_count(&MyNdb, pTab, _parallelism, &rows, 
 		     (NdbOperation::LockMode)_lock) != 0){
       return NDBT_ProgramExit(NDBT_FAILED);
@@ -119,7 +119,7 @@ int main(int argc, char** argv){
 int 
 select_count(Ndb* pNdb, const NdbDictionary::Table* pTab,
 	     int parallelism,
-	     int* count_rows,
+	     Uint64* count_rows,
 	     NdbOperation::LockMode lock){
   
   int                  retryAttempt = 0;

Thread
bzr commit into mysql-5.1 branch (stewart:2946) Stewart Smith8 Oct