List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:October 7 2008 10:51am
Subject:Re: bzr commit into mysql-6.0-backup branch (hema:2699) WL#4568
View as plain text  
Hema,

The patch looks good. Great that we introduce more order into our backup tests.

Rafal

Hema Sridharan wrote:
> #At file:///export/home/tmp/rpl/wl4568f/mysql-6.0-backup/
> 
>  2699 Hema Sridharan	2008-10-03
>       WL#4568: 
>       1) Moving all tests from bakcup suite to backup_engines suite.
>       2) Moving all tests from mysql-test/t/ to backup suite.
> added:
>   mysql-test/suite/backup/
>   mysql-test/suite/backup/r/
>   mysql-test/suite/backup/t/
>   mysql-test/suite/backup/t/disabled.def
> renamed:
>   mysql-test/r/backup.result => mysql-test/suite/backup/r/backup.result
>   mysql-test/r/backup_backupdir.result =>
> mysql-test/suite/backup/r/backup_backupdir.result
>   mysql-test/r/backup_blob.result => mysql-test/suite/backup/r/backup_blob.result
>   mysql-test/r/backup_charsets.result =>
> mysql-test/suite/backup/r/backup_charsets.result
>   mysql-test/r/backup_commit_backup.result =>
> mysql-test/suite/backup/r/backup_commit_backup.result
>   mysql-test/r/backup_commit_blocker.result =>
> mysql-test/suite/backup/r/backup_commit_blocker.result
>   mysql-test/r/backup_commit_restore.result =>
> mysql-test/suite/backup/r/backup_commit_restore.result
>   mysql-test/r/backup_compression.result =>
> mysql-test/suite/backup/r/backup_compression.result
>   mysql-test/r/backup_concurrent.result =>
> mysql-test/suite/backup/r/backup_concurrent.result
>   mysql-test/r/backup_db_grants.result =>
> mysql-test/suite/backup/r/backup_db_grants.result
>   mysql-test/r/backup_ddl_blocker.result =>
> mysql-test/suite/backup/r/backup_ddl_blocker.result
>   mysql-test/r/backup_default.result =>
> mysql-test/suite/backup/r/backup_default.result
>   mysql-test/r/backup_errors.result =>
> mysql-test/suite/backup/r/backup_errors.result
>   mysql-test/r/backup_fkey.result => mysql-test/suite/backup/r/backup_fkey.result
>   mysql-test/r/backup_lock_myisam.result =>
> mysql-test/suite/backup/r/backup_lock_myisam.result
>   mysql-test/r/backup_logs.result => mysql-test/suite/backup/r/backup_logs.result
>   mysql-test/r/backup_logs_output.result =>
> mysql-test/suite/backup/r/backup_logs_output.result
>   mysql-test/r/backup_many_dbs.result =>
> mysql-test/suite/backup/r/backup_many_dbs.result
>   mysql-test/r/backup_multi_blocks.result =>
> mysql-test/suite/backup/r/backup_multi_blocks.result
>   mysql-test/r/backup_myisam1.result =>
> mysql-test/suite/backup/r/backup_myisam1.result
>   mysql-test/r/backup_myisam2.result =>
> mysql-test/suite/backup/r/backup_myisam2.result
>   mysql-test/r/backup_no_be.result =>
> mysql-test/suite/backup/r/backup_no_be.result
>   mysql-test/r/backup_no_data.result =>
> mysql-test/suite/backup/r/backup_no_data.result
>   mysql-test/r/backup_no_engine.result =>
> mysql-test/suite/backup/r/backup_no_engine.result
>   mysql-test/r/backup_nodata_driver.result =>
> mysql-test/suite/backup/r/backup_nodata_driver.result
>   mysql-test/r/backup_objects.result =>
> mysql-test/suite/backup/r/backup_objects.result
>   mysql-test/r/backup_procedures.result =>
> mysql-test/suite/backup/r/backup_procedures.result
>   mysql-test/r/backup_securefilepriv.result =>
> mysql-test/suite/backup/r/backup_securefilepriv.result
>   mysql-test/r/backup_security.result =>
> mysql-test/suite/backup/r/backup_security.result
>   mysql-test/r/backup_snapshot.result =>
> mysql-test/suite/backup/r/backup_snapshot.result
>   mysql-test/r/backup_tablespace.result =>
> mysql-test/suite/backup/r/backup_tablespace.result
>   mysql-test/r/backup_timeout.result =>
> mysql-test/suite/backup/r/backup_timeout.result
>   mysql-test/r/backup_triggers_and_events.result =>
> mysql-test/suite/backup/r/backup_triggers_and_events.result
>   mysql-test/r/backup_view_on_view.result =>
> mysql-test/suite/backup/r/backup_view_on_view.result
>   mysql-test/r/backup_views.result =>
> mysql-test/suite/backup/r/backup_views.result
>   mysql-test/suite/backup => mysql-test/suite/backup_engines
>   mysql-test/t/backup.test => mysql-test/suite/backup/t/backup.test
>   mysql-test/t/backup_backupdir.test =>
> mysql-test/suite/backup/t/backup_backupdir.test
>   mysql-test/t/backup_blob.test => mysql-test/suite/backup/t/backup_blob.test
>   mysql-test/t/backup_charsets.test =>
> mysql-test/suite/backup/t/backup_charsets.test
>   mysql-test/t/backup_commit_backup.test =>
> mysql-test/suite/backup/t/backup_commit_backup.test
>   mysql-test/t/backup_commit_blocker.test =>
> mysql-test/suite/backup/t/backup_commit_blocker.test
>   mysql-test/t/backup_commit_restore.test =>
> mysql-test/suite/backup/t/backup_commit_restore.test
>   mysql-test/t/backup_compression.test =>
> mysql-test/suite/backup/t/backup_compression.test
>   mysql-test/t/backup_concurrent.test =>
> mysql-test/suite/backup/t/backup_concurrent.test
>   mysql-test/t/backup_db_grants.test =>
> mysql-test/suite/backup/t/backup_db_grants.test
>   mysql-test/t/backup_ddl_blocker.test =>
> mysql-test/suite/backup/t/backup_ddl_blocker.test
>   mysql-test/t/backup_default.test =>
> mysql-test/suite/backup/t/backup_default.test
>   mysql-test/t/backup_errors.test => mysql-test/suite/backup/t/backup_errors.test
>   mysql-test/t/backup_fkey.test => mysql-test/suite/backup/t/backup_fkey.test
>   mysql-test/t/backup_lock_myisam.test =>
> mysql-test/suite/backup/t/backup_lock_myisam.test
>   mysql-test/t/backup_logs.test => mysql-test/suite/backup/t/backup_logs.test
>   mysql-test/t/backup_logs_output.test =>
> mysql-test/suite/backup/t/backup_logs_output.test
>   mysql-test/t/backup_many_dbs.test =>
> mysql-test/suite/backup/t/backup_many_dbs.test
>   mysql-test/t/backup_multi_blocks.test =>
> mysql-test/suite/backup/t/backup_multi_blocks.test
>   mysql-test/t/backup_myisam1-master.opt =>
> mysql-test/suite/backup/t/backup_myisam1-master.opt
>   mysql-test/t/backup_myisam1.test =>
> mysql-test/suite/backup/t/backup_myisam1.test
>   mysql-test/t/backup_myisam2.test =>
> mysql-test/suite/backup/t/backup_myisam2.test
>   mysql-test/t/backup_no_be.test => mysql-test/suite/backup/t/backup_no_be.test
>   mysql-test/t/backup_no_data.test =>
> mysql-test/suite/backup/t/backup_no_data.test
>   mysql-test/t/backup_no_engine.test =>
> mysql-test/suite/backup/t/backup_no_engine.test
>   mysql-test/t/backup_nodata_driver.test =>
> mysql-test/suite/backup/t/backup_nodata_driver.test
>   mysql-test/t/backup_objects.test =>
> mysql-test/suite/backup/t/backup_objects.test
>   mysql-test/t/backup_procedures.test =>
> mysql-test/suite/backup/t/backup_procedures.test
>   mysql-test/t/backup_securefilepriv-master.opt =>
> mysql-test/suite/backup/t/backup_securefilepriv-master.opt
>   mysql-test/t/backup_securefilepriv.test =>
> mysql-test/suite/backup/t/backup_securefilepriv.test
>   mysql-test/t/backup_security.test =>
> mysql-test/suite/backup/t/backup_security.test
>   mysql-test/t/backup_snapshot.opt =>
> mysql-test/suite/backup/t/backup_snapshot.opt
>   mysql-test/t/backup_snapshot.test =>
> mysql-test/suite/backup/t/backup_snapshot.test
>   mysql-test/t/backup_tablespace.test =>
> mysql-test/suite/backup/t/backup_tablespace.test
>   mysql-test/t/backup_timeout.test =>
> mysql-test/suite/backup/t/backup_timeout.test
>   mysql-test/t/backup_triggers_and_events.test =>
> mysql-test/suite/backup/t/backup_triggers_and_events.test
>   mysql-test/t/backup_view_on_view.test =>
> mysql-test/suite/backup/t/backup_view_on_view.test
>   mysql-test/t/backup_views.test => mysql-test/suite/backup/t/backup_views.test
> modified:
>   mysql-test/suite/backup_engines/t/backup_functions.test
>   mysql-test/suite/backup_engines/t/backup_procedures.test
>   mysql-test/suite/backup_engines/t/backup_triggers.test
> 
> === added directory 'mysql-test/suite/backup'
> === added directory 'mysql-test/suite/backup/r'
> === renamed file 'mysql-test/r/backup.result' =>
> 'mysql-test/suite/backup/r/backup.result'
> === renamed file 'mysql-test/r/backup_backupdir.result' =>
> 'mysql-test/suite/backup/r/backup_backupdir.result'
> === renamed file 'mysql-test/r/backup_blob.result' =>
> 'mysql-test/suite/backup/r/backup_blob.result'
> === renamed file 'mysql-test/r/backup_charsets.result' =>
> 'mysql-test/suite/backup/r/backup_charsets.result'
> === renamed file 'mysql-test/r/backup_commit_backup.result' =>
> 'mysql-test/suite/backup/r/backup_commit_backup.result'
> === renamed file 'mysql-test/r/backup_commit_blocker.result' =>
> 'mysql-test/suite/backup/r/backup_commit_blocker.result'
> === renamed file 'mysql-test/r/backup_commit_restore.result' =>
> 'mysql-test/suite/backup/r/backup_commit_restore.result'
> === renamed file 'mysql-test/r/backup_compression.result' =>
> 'mysql-test/suite/backup/r/backup_compression.result'
> === renamed file 'mysql-test/r/backup_concurrent.result' =>
> 'mysql-test/suite/backup/r/backup_concurrent.result'
> === renamed file 'mysql-test/r/backup_db_grants.result' =>
> 'mysql-test/suite/backup/r/backup_db_grants.result'
> === renamed file 'mysql-test/r/backup_ddl_blocker.result' =>
> 'mysql-test/suite/backup/r/backup_ddl_blocker.result'
> === renamed file 'mysql-test/r/backup_default.result' =>
> 'mysql-test/suite/backup/r/backup_default.result'
> === renamed file 'mysql-test/r/backup_errors.result' =>
> 'mysql-test/suite/backup/r/backup_errors.result'
> === renamed file 'mysql-test/r/backup_fkey.result' =>
> 'mysql-test/suite/backup/r/backup_fkey.result'
> === renamed file 'mysql-test/r/backup_lock_myisam.result' =>
> 'mysql-test/suite/backup/r/backup_lock_myisam.result'
> === renamed file 'mysql-test/r/backup_logs.result' =>
> 'mysql-test/suite/backup/r/backup_logs.result'
> === renamed file 'mysql-test/r/backup_logs_output.result' =>
> 'mysql-test/suite/backup/r/backup_logs_output.result'
> === renamed file 'mysql-test/r/backup_many_dbs.result' =>
> 'mysql-test/suite/backup/r/backup_many_dbs.result'
> === renamed file 'mysql-test/r/backup_multi_blocks.result' =>
> 'mysql-test/suite/backup/r/backup_multi_blocks.result'
> === renamed file 'mysql-test/r/backup_myisam1.result' =>
> 'mysql-test/suite/backup/r/backup_myisam1.result'
> === renamed file 'mysql-test/r/backup_myisam2.result' =>
> 'mysql-test/suite/backup/r/backup_myisam2.result'
> === renamed file 'mysql-test/r/backup_no_be.result' =>
> 'mysql-test/suite/backup/r/backup_no_be.result'
> === renamed file 'mysql-test/r/backup_no_data.result' =>
> 'mysql-test/suite/backup/r/backup_no_data.result'
> === renamed file 'mysql-test/r/backup_no_engine.result' =>
> 'mysql-test/suite/backup/r/backup_no_engine.result'
> === renamed file 'mysql-test/r/backup_nodata_driver.result' =>
> 'mysql-test/suite/backup/r/backup_nodata_driver.result'
> === renamed file 'mysql-test/r/backup_objects.result' =>
> 'mysql-test/suite/backup/r/backup_objects.result'
> === renamed file 'mysql-test/r/backup_procedures.result' =>
> 'mysql-test/suite/backup/r/backup_procedures.result'
> === renamed file 'mysql-test/r/backup_securefilepriv.result' =>
> 'mysql-test/suite/backup/r/backup_securefilepriv.result'
> === renamed file 'mysql-test/r/backup_security.result' =>
> 'mysql-test/suite/backup/r/backup_security.result'
> === renamed file 'mysql-test/r/backup_snapshot.result' =>
> 'mysql-test/suite/backup/r/backup_snapshot.result'
> === renamed file 'mysql-test/r/backup_tablespace.result' =>
> 'mysql-test/suite/backup/r/backup_tablespace.result'
> === renamed file 'mysql-test/r/backup_timeout.result' =>
> 'mysql-test/suite/backup/r/backup_timeout.result'
> === renamed file 'mysql-test/r/backup_triggers_and_events.result' =>
> 'mysql-test/suite/backup/r/backup_triggers_and_events.result'
> === renamed file 'mysql-test/r/backup_view_on_view.result' =>
> 'mysql-test/suite/backup/r/backup_view_on_view.result'
> === renamed file 'mysql-test/r/backup_views.result' =>
> 'mysql-test/suite/backup/r/backup_views.result'
> === added directory 'mysql-test/suite/backup/t'
> === renamed file 'mysql-test/t/backup.test' =>
> 'mysql-test/suite/backup/t/backup.test'
> === renamed file 'mysql-test/t/backup_backupdir.test' =>
> 'mysql-test/suite/backup/t/backup_backupdir.test'
> === renamed file 'mysql-test/t/backup_blob.test' =>
> 'mysql-test/suite/backup/t/backup_blob.test'
> === renamed file 'mysql-test/t/backup_charsets.test' =>
> 'mysql-test/suite/backup/t/backup_charsets.test'
> === renamed file 'mysql-test/t/backup_commit_backup.test' =>
> 'mysql-test/suite/backup/t/backup_commit_backup.test'
> === renamed file 'mysql-test/t/backup_commit_blocker.test' =>
> 'mysql-test/suite/backup/t/backup_commit_blocker.test'
> === renamed file 'mysql-test/t/backup_commit_restore.test' =>
> 'mysql-test/suite/backup/t/backup_commit_restore.test'
> === renamed file 'mysql-test/t/backup_compression.test' =>
> 'mysql-test/suite/backup/t/backup_compression.test'
> === renamed file 'mysql-test/t/backup_concurrent.test' =>
> 'mysql-test/suite/backup/t/backup_concurrent.test'
> === renamed file 'mysql-test/t/backup_db_grants.test' =>
> 'mysql-test/suite/backup/t/backup_db_grants.test'
> === renamed file 'mysql-test/t/backup_ddl_blocker.test' =>
> 'mysql-test/suite/backup/t/backup_ddl_blocker.test'
> === renamed file 'mysql-test/t/backup_default.test' =>
> 'mysql-test/suite/backup/t/backup_default.test'
> === renamed file 'mysql-test/t/backup_errors.test' =>
> 'mysql-test/suite/backup/t/backup_errors.test'
> === renamed file 'mysql-test/t/backup_fkey.test' =>
> 'mysql-test/suite/backup/t/backup_fkey.test'
> === renamed file 'mysql-test/t/backup_lock_myisam.test' =>
> 'mysql-test/suite/backup/t/backup_lock_myisam.test'
> === renamed file 'mysql-test/t/backup_logs.test' =>
> 'mysql-test/suite/backup/t/backup_logs.test'
> === renamed file 'mysql-test/t/backup_logs_output.test' =>
> 'mysql-test/suite/backup/t/backup_logs_output.test'
> === renamed file 'mysql-test/t/backup_many_dbs.test' =>
> 'mysql-test/suite/backup/t/backup_many_dbs.test'
> === renamed file 'mysql-test/t/backup_multi_blocks.test' =>
> 'mysql-test/suite/backup/t/backup_multi_blocks.test'
> === renamed file 'mysql-test/t/backup_myisam1-master.opt' =>
> 'mysql-test/suite/backup/t/backup_myisam1-master.opt'
> === renamed file 'mysql-test/t/backup_myisam1.test' =>
> 'mysql-test/suite/backup/t/backup_myisam1.test'
> === renamed file 'mysql-test/t/backup_myisam2.test' =>
> 'mysql-test/suite/backup/t/backup_myisam2.test'
> === renamed file 'mysql-test/t/backup_no_be.test' =>
> 'mysql-test/suite/backup/t/backup_no_be.test'
> === renamed file 'mysql-test/t/backup_no_data.test' =>
> 'mysql-test/suite/backup/t/backup_no_data.test'
> === renamed file 'mysql-test/t/backup_no_engine.test' =>
> 'mysql-test/suite/backup/t/backup_no_engine.test'
> === renamed file 'mysql-test/t/backup_nodata_driver.test' =>
> 'mysql-test/suite/backup/t/backup_nodata_driver.test'
> === renamed file 'mysql-test/t/backup_objects.test' =>
> 'mysql-test/suite/backup/t/backup_objects.test'
> === renamed file 'mysql-test/t/backup_procedures.test' =>
> 'mysql-test/suite/backup/t/backup_procedures.test'
> === renamed file 'mysql-test/t/backup_securefilepriv-master.opt' =>
> 'mysql-test/suite/backup/t/backup_securefilepriv-master.opt'
> === renamed file 'mysql-test/t/backup_securefilepriv.test' =>
> 'mysql-test/suite/backup/t/backup_securefilepriv.test'
> === renamed file 'mysql-test/t/backup_security.test' =>
> 'mysql-test/suite/backup/t/backup_security.test'
> === renamed file 'mysql-test/t/backup_snapshot.opt' =>
> 'mysql-test/suite/backup/t/backup_snapshot.opt'
> === renamed file 'mysql-test/t/backup_snapshot.test' =>
> 'mysql-test/suite/backup/t/backup_snapshot.test'
> === renamed file 'mysql-test/t/backup_tablespace.test' =>
> 'mysql-test/suite/backup/t/backup_tablespace.test'
> === renamed file 'mysql-test/t/backup_timeout.test' =>
> 'mysql-test/suite/backup/t/backup_timeout.test'
> === renamed file 'mysql-test/t/backup_triggers_and_events.test' =>
> 'mysql-test/suite/backup/t/backup_triggers_and_events.test'
> === renamed file 'mysql-test/t/backup_view_on_view.test' =>
> 'mysql-test/suite/backup/t/backup_view_on_view.test'
> === renamed file 'mysql-test/t/backup_views.test' =>
> 'mysql-test/suite/backup/t/backup_views.test'
> === added file 'mysql-test/suite/backup/t/disabled.def'
> --- a/mysql-test/suite/backup/t/disabled.def	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/suite/backup/t/disabled.def	2008-10-03 15:54:23 +0000
> @@ -0,0 +1,14 @@
> +##############################################################################
> +#
> +#  List the test cases that are to be disabled temporarily.
> +#
> +#  Separate the test case name and the comment with ':'.
> +#
> +#    <testcasename> : BUG#<xxxx> <date disabled> <disabler>
> <comment>
> +#
> +#  Do not use any TAB characters for whitespace.
> +#
> +##############################################################################
> +backup_no_engine     : Bug#36021 2008-04-13 rsomla server crashes when openning
> table with unknown storage engine
> +backup_triggers_and_events  : Bug#37762 2008-07-01 rafal Test fails on remove_file
> for unknown reasons
> +backup_no_be                : Bug#38023 2008-07-16 rafal Test triggers valgrind
> warnings described in the bug
> 
> === renamed directory 'mysql-test/suite/backup' =>
> 'mysql-test/suite/backup_engines'
> === modified file 'mysql-test/suite/backup_engines/t/backup_functions.test'
> --- a/mysql-test/suite/backup/t/backup_functions.test	2008-08-12 03:22:05 +0000
> +++ b/mysql-test/suite/backup_engines/t/backup_functions.test	2008-10-03 15:54:23
> +0000
> @@ -5,7 +5,7 @@
>  # after backup and Restore.
>  ###############################################################################
>  --source include/not_embedded.inc
> ---source suite/backup/include/backup_engine.inc
> +--source suite/backup_engines/include/backup_engine.inc
>  --source include/have_debug.inc
>  
>  connect (backup,localhost,root,,);
> 
> === modified file 'mysql-test/suite/backup_engines/t/backup_procedures.test'
> --- a/mysql-test/suite/backup/t/backup_procedures.test	2008-08-12 03:22:05 +0000
> +++ b/mysql-test/suite/backup_engines/t/backup_procedures.test	2008-10-03 15:54:23
> +0000
> @@ -5,7 +5,7 @@
>  #  storage engines.
>  ###############################################################################
>  --source include/not_embedded.inc
> ---source suite/backup/include/backup_engine.inc
> +--source suite/backup_engines/include/backup_engine.inc
>  --source include/have_debug.inc
>  
>  connect (backup,localhost,root,,);
> 
> === modified file 'mysql-test/suite/backup_engines/t/backup_triggers.test'
> --- a/mysql-test/suite/backup/t/backup_triggers.test	2008-08-12 03:22:05 +0000
> +++ b/mysql-test/suite/backup_engines/t/backup_triggers.test	2008-10-03 15:54:23
> +0000
> @@ -7,7 +7,7 @@
>  ###################################################################
>  
>  --source include/not_embedded.inc
> ---source suite/backup/include/backup_engine.inc
> +--source suite/backup_engines/include/backup_engine.inc
>  --source include/have_debug.inc
>  
>  connect (backup,localhost,root,,);
> 
> 
Thread
bzr commit into mysql-6.0-backup branch (hema:2699) WL#4568Hema Sridharan3 Oct
  • RE: bzr commit into mysql-6.0-backup branch (hema:2699) WL#4568Chuck Bell3 Oct
  • Re: bzr commit into mysql-6.0-backup branch (hema:2699) WL#4568Rafal Somla7 Oct
  • Re: bzr commit into mysql-6.0-backup branch (hema:2699) WL#4568Jørgen Løland8 Oct