On Oct 02, Chad MILLER wrote:
> #At file:///Users/cmiller/work/mysqlbzr/5.0-bugteam--bug11122/
> 2653 Chad MILLER 2008-10-02
> Bug#11122: Server won't always start when cold-booting after a crash
> The grep expression that finds a running "mysqld" program fails if the
> "mysqld_safe" is running with the same PID.
> Now, excise "ps" output that has the word " grep" or "mysqld_safe" in
> it, to be a little more certain that the matched process is not a false
> positive hit. This will fail when the path to mysqld contains either
> of those two names, which should be acceptable.
> Additionally, some text to search could be truncated if very long.
> Expand the number of lines "ps" emits.
ok to push,
but fix a comment:
> === modified file 'configure.in'
> --- a/configure.in 2008-07-19 03:46:03 +0000
> +++ b/configure.in 2008-10-02 16:25:52 +0000
> @@ -504,46 +504,54 @@ then
> -# Lock for PS
> +# Look for PS usage. We use double dollar-signs in FIND_PROC because this
> +# value is written to a makefile, which interprets away one level of
> +# dollar-signs. So, interpretation stages are m4 and then shell in autoconf,
> +# then Make, then shell .
> +# We use grep -E Foo space-or-EOL so that we don't falsely match "Foo_safe" .
you forgot to correct the comment, it still says "grep -E"
> +# Assumption is that if there are parameters, the system represents them using
> +# space as a seperator. This has the side effect that the matching expression
Regards / Mit vielen Grüßen,
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring