Re: bzr commit into mysql-6.0-backup branch (oystein.grovlen:2699) Bug#39089 WL#4384

[Øystein Grøvlen]

Hi,

Forgot one item:

Rafal Somla wrote:
> 6. Remove incorrect "never errors" comments:
>  - at info.get_db_object() call inside find_obj() (image_info.cc) - this 
> method
>    can error and signal this by returning NULL.

I do not consider not finding an object an error.  It would be an error 
if it was not able to determine whether an object existed or not.

On the other hand, comment about error or not is probably irrelevant 
here since the result is just returned.

>  - when Backup_info instance is created inside
>    Backup_restore_ctx::prepare_for_backup(). The constructor detects and 
> logs
>    errors.

I agree that this is misleading.  Will change.

--
Øystein