RE: bzr commit into mysql-6.0-falcon-team branch (olav:2845) Bug#39575

[Vladislav Vaintroub]

Olav, nice catch
Ok to push.


> -----Original Message-----
> From: Olav Sandstaa [mailto:olav@stripped]
> Sent: Thursday, October 02, 2008 11:02 AM
> To: commits@stripped
> Subject: bzr commit into mysql-6.0-falcon-team branch (olav:2845)
> Bug#39575
> 
> #At file:///home/os136802/mysql/develop/repo/falcon-sparc/
> 
>  2845 Olav Sandstaa	2008-10-02
>       Fix for Bug#39575 Falcon crashes during loading of large dataset
> 
>       Changed datatype for the offset within the serial log file from
> 32 bit to 64 bit
>       in order to handle that the serial log file can grow beyond 4 GB.
> modified:
>   storage/falcon/SerialLogWindow.cpp
> 
> === modified file 'storage/falcon/SerialLogWindow.cpp'
> 
> === modified file 'storage/falcon/SerialLogWindow.cpp'
> --- a/storage/falcon/SerialLogWindow.cpp	2008-03-11 16:15:47 +0000
> +++ b/storage/falcon/SerialLogWindow.cpp	2008-10-02 09:01:39 +0000
> @@ -117,7 +117,7 @@
>  void SerialLogWindow::write(SerialLogBlock *block)
>  {
>  	uint32 length = ROUNDUP(block->length, sectorSize);
> -	uint32 offset = (int) (origin + ((UCHAR*) block - buffer));
> +	int64 offset = origin + ((UCHAR*) block - buffer);
>  	ASSERT(length <= bufferLength);
> 
>  	try
> 
> 
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:
> http://lists.mysql.com/commits?unsub=1