Jorgen,
Here is a new patch.
http://lists.mysql.com/commits/54985
Chuck
> Even though there were no reported problems in the backup
> branch, I think this patch was valuable for backup as well.
> The refactoring made the code much easier to read. Good work!
Thanks.
> Requests:
> ---------
> 1. Either don't change backupdir to full path or document
> that backupdir is changed [1] 2. The other reviewer should
> verify that the backup tests pass on rpl branch since I was
> not able to run the tests [2]
1. I read the original comments wrong it seems. It is not necessary to copy
the full path. This portion was removed.
2. I tried on both Windows and Ubuntu x86-64. I had no problems running the
tests.
...
> main.backup_myisam1 [ fail ] Found warnings in
> server log file!
> @log_error
> /mysql/mysql-6.0-rpl/mysql-test/var/1/mysqld.1/mysqld.err
> log_error
> 081001 10:07:48 [ERROR] Falcon: Exception 'Invalid serial log
> directory path
> "/mysql/mysql-6.0-rpl/mysql-test/var/1/mysqld.1/data/"'
> during initialization
> 081001 10:07:48 [ERROR] Plugin 'Falcon' init function returned error.
> 081001 10:07:48 [ERROR] Plugin 'Falcon' registration as a
> STORAGE ENGINE failed.
> ^ Found warnings!!
> ---->8-----
>
> There's probably something I'm doing wrong with the rpl
> version of mtr.
Weird.
