List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:October 1 2008 1:10pm
Subject:Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)
WL#4534
View as plain text  
Ingo Strüwing wrote:
> Hi Rafal,
> 
> Rafal Somla, 30.09.2008 14:54:
>> ...
>> I think it would be nicer to use the library, instead of compiling
>> library sources. That is:
>>
>> mysqlbackup_SOURCES = mysqlbackup.cc
>>
>> mysqlbackup_LDADD = $(LDADD) $(CXXLDFLAGS)
>> $(top_stcdir)/sql/backup/libbackupstream.la
> 
> I tried it. It failed on a fresh rebuild. client/ is built before
> sql/backup/. So the library is missing when mysqlbackup is linked. I am
> not sure if reversing the order would be a good idea.
> 
> We do probably need to split libbackupstream out of sql/backup/ and
> build it before client/.
>

I think it would be a good thing to separate libbackupstream so that it is 
avaliable to clients outside sql/backup/. However I don't know where to put it, 
how to arrange this and whether we, developers, are entitled to make such decisions.

Rafal
Thread
bzr commit into mysql-6.0-backup branch (ingo.struewing:2693) WL#4534Ingo Struewing30 Sep
  • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)WL#4534Rafal Somla30 Sep
    • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)WL#4534Ingo Strüwing30 Sep
      • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)WL#4534Rafal Somla1 Oct
    • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)WL#4534Ingo Strüwing30 Sep
      • Re: bzr commit into mysql-6.0-backup branch (ingo.struewing:2693)WL#4534Rafal Somla1 Oct