Re: bzr commit into mysql-5.1 branch (davi:2746) Bug#35164

[Konstantin Osipov]

* Davi Arnaut <Davi.Arnaut@stripped> [08/09/29 18:59]:
>  2746 Davi Arnaut	2008-09-29
>       Bug#35164: Large number of invalid pthread_attr_setschedparam calls
>       
>       Deprecated --skip-thread-priority startup option as newer version of
>       the server won't change the thread priorities by default.

>    {"skip-thread-priority", OPT_SKIP_PRIOR,
> -   "Don't give threads different priorities.", 0, 0, 0, GET_NO_ARG, NO_ARG,
> +   "Don't give threads different priorities. Deprecated option.", 0, 0, 0,
> GET_NO_ARG, NO_ARG,
>     DEFAULT_SKIP_THREAD_PRIORITY, 0, 0, 0, 0, 0},

Please say why: this option used to give marginal improvement on
platforms it worked on, and significant slowdown on others, and
hence was removed. Please check the exact wording with the #docs.

>  #ifdef HAVE_REPLICATION
>    {"slave-load-tmpdir", OPT_SLAVE_LOAD_TMPDIR,
> @@ -7871,6 +7871,9 @@ mysqld_get_one_option(int optid,
>      break;
>    case (int) OPT_SKIP_PRIOR:
>      opt_specialflag|= SPECIAL_NO_PRIOR;
> +    sql_print_warning("The --skip-thread-priority startup option is deprecated "
> +                      "and will be removed in MySQL 7.0. MySQL 6.0 and onward "
> +                      "versions won't give threads different priorities.");
>      break;
>    case (int) OPT_SKIP_LOCK:
>      opt_external_locking=0;

--