List:Commits« Previous MessageNext Message »
From:John H. Embretsen Date:September 29 2008 8:43am
Subject:Re: bzr commit into mysql-falcon branch (hky:289)
View as plain text  
Hakan,

Looks OK to me, from a view 30000 feet above the nitty gritty details. 
You are the PHP master, feel free to push :)

-- 
John


Hakan Kuecuekyilmaz wrote:
> #At bzr+ssh://bk-internal.mysql.com/bzrroot/mysql-falcon/
> 
>   289 Hakan Kuecuekyilmaz	2008-09-29
>       Various minor fixes.
> modified:
>   dbt2/dbt2.css
>   dbt2/historical_dbt2_overview_graph.php
>   dbt2/wait_for_dbt2_and_collect.sh
>   dbt2/weekly_dbt2_overview_cpu_graph.php
>   dbt2/weekly_dbt2_overview_graph.php
>   falcon_bug_statistic/fbs.css
>   weekly_falcon_test_overview/vmware_start.sh
> 
> per-file messages:
>   dbt2/dbt2.css
>     Set height to auto so that the border
>     around the popup is expanded correctly.
>   dbt2/historical_dbt2_overview_graph.php
>     ** Some PHP versions use $_ENV['HOSTNAME'] others $_SERVER['HOSTNAME'].
>     ** max() also accepts arrays as parameters.
>   dbt2/wait_for_dbt2_and_collect.sh
>     Use correct script to generate historical
>     DBT2 graphs.
>   dbt2/weekly_dbt2_overview_cpu_graph.php
>     Some PHP versions use $_ENV['HOSTNAME'] others $_SERVER['HOSTNAME']
>   dbt2/weekly_dbt2_overview_graph.php
>     Some PHP versions use $_ENV['HOSTNAME'] others $_SERVER['HOSTNAME']
>   falcon_bug_statistic/fbs.css
>     Fixed comment.
>   weekly_falcon_test_overview/vmware_start.sh
>     Whitespace.

Thread
bzr commit into mysql-falcon branch (hky:289) Hakan Kuecuekyilmaz29 Sep
  • Re: bzr commit into mysql-falcon branch (hky:289)John H. Embretsen29 Sep