* Sergey Vojtovich <svoj@stripped> [08/09/25 18:58]:
> 2832 Sergey Vojtovich 2008-09-25
> BUG#34892 - Transaction handling in select_create::abort let's Falcon fail
trans_rollback_statement() should be done on top level, when we
send the error message.
Is there any reason why this doesn't work?
Perhaps worth adding an explanation in a comment then.
>
> === modified file 'sql/sql_insert.cc'
> --- a/sql/sql_insert.cc 2008-09-16 17:58:49 +0000
> +++ b/sql/sql_insert.cc 2008-09-25 14:39:39 +0000
> @@ -3310,6 +3310,7 @@ void select_insert::abort() {
> thd->transaction.stmt.modified_non_trans_table);
> table->file->ha_release_auto_increment();
> }
> + trans_rollback_stmt(thd);
>
> DBUG_VOID_RETURN;
> }
--